Add rule call constructor

[muno92]

Implementation for phpstan/phpstan/issues/7022.

Notes

• Check calling __construct more than twice in constructor is out of scope
  Because it is a bit difficult.

[zonuexe]

Already pointed out how to define rules
phpstan/phpstan#7022 (comment) phpstan/phpstan#7022 (comment)

[muno92]

Already pointed out how to define rules phpstan/phpstan#7022 (comment) phpstan/phpstan#7022 (comment)

I'll split Rule

[staabm]

Suggested change

	: ['__construct should not be called outside constructor.'];
	: ['__construct() should not be called outside constructor.'];

[muno92]

LGTM

This message is written in other lines, so I changed those.

[ondrejmirtes]

Thank you. I'm gonna take over and bring it over the finish line 😊

[sasezaki]

[IMO]
The rules in this PR implementation also determine that $self->__construct is also a violation,
eg. https://phpstan.org/r/0affd0af-b9e0-4ffe-9a69-ff7915120d19

but since the number of use cases is expected to be small, it can be ignored.

[muno92]

[IMO]
The rules in this PR implementation also determine that $self->__construct is also a violation,
eg. https://phpstan.org/r/0affd0af-b9e0-4ffe-9a69-ff7915120d19
but since the number of use cases is expected to be small, it can be ignored.

I think, above case is no need of using __construct().
https://3v4l.org/v25j9

Is this wrong understanding?

[sasezaki]

I think, above case is no need of using __construct().

Yep, it can be rewrite such of your example.
There is no problem with $self->__construct being a rule error, I said.

[muno92]

Yep, it can be rewrite such of your example. There is no problem with $self->__construct being a rule error, I said.

Sorry. I misread your first comment.

[ondrejmirtes]

I've pushed some improvements, feel free to check out the commits :)

[ondrejmirtes]

Thank you.

[muno92]

Thank you, too.

[ondrejmirtes]

FYI I've moved these rules to phpstan-strict-rules (124b30f, phpstan/phpstan-strict-rules@0c82c96) because it's a better fit there. According to some opinions, these rules are too opinionated to be part of the "mainstream" PHPStan. Thanks for understanding.