Prevent allowing direct call to __construct

[DaveLiddament]

Feature request

I don't think code should be allowed to call __construct method.

E.g. $bob->__construct("Jane");

https://phpstan.org/r/e261ee44-70c1-486b-958e-dc8abc1231d9

[DaveLiddament]

I'm happy to give this a go at providing an implementation in the next few days.

[mavimo]

@DaveLiddament shouldn't be detected by conding-standard checker than static-analyzer?

[ondrejmirtes]

@mavimo If you’re concerned about semantics and not code formatting, it’s always easier to write the rule using PHPStan’s AST and type inference.

I’d consider this for phpstan-strict-rules, thank you.

[canvural]

I guess this is now in PHPStan itself with this PR.

https://phpstan.org/r/dd092672-9545-4e8c-804f-131178e27fb7

[ondrejmirtes]

Yes. It's gonna be in bleedingEdge in 1.6.0. Based on feedback I might move it to phpstan-strict-rules before 2.0 comes out.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.