Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented ConstantStringType inference for str_repeat #1030

Merged
merged 3 commits into from Feb 22, 2022
Merged

implemented ConstantStringType inference for str_repeat #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
255b97f
implemented ConstantStringType inference to StrRepeatFunctionReturnTy…
clxmstaab Feb 22, 2022
954e089
adjusted test-expectations for the more precise result
clxmstaab Feb 22, 2022
e3df0c3
don't crash on negative multiplier
clxmstaab Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Type/Php/StrRepeatFunctionReturnTypeExtension.php
View file
Open in desktop
Expand Up @@ -12,9 +12,11 @@
use PHPStan\Type\DynamicFunctionReturnTypeExtension;
use PHPStan\Type\IntegerRangeType;
use PHPStan\Type\IntersectionType;
use PHPStan\Type\NeverType;
use PHPStan\Type\StringType;
use PHPStan\Type\Type;
use function count;
use function str_repeat;

class StrRepeatFunctionReturnTypeExtension implements DynamicFunctionReturnTypeExtension
{
Expand Down Expand Up @@ -42,6 +44,14 @@ public function getTypeFromFunctionCall(
return new ConstantStringType('');
}

if ($multiplierType instanceof ConstantIntegerType && $multiplierType->getValue() < 0) {
return new NeverType();
}

if ($inputType instanceof ConstantStringType && $multiplierType instanceof ConstantIntegerType) {
return new ConstantStringType(str_repeat($inputType->getValue(), $multiplierType->getValue()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code will crash when analysing code like this: https://3v4l.org/XRaOj

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. added a test and made it return NeverType on negative multiplier

}

$accessoryTypes = [];
if ($inputType->isNonEmptyString()->yes()) {
if (IntegerRangeType::fromInterval(1, null)->isSuperTypeOf($multiplierType)->yes()) {
Expand Down
6 changes: 4 additions & 2 deletions tests/PHPStan/Analyser/data/literal-string.php
View file
Open in desktop
Expand Up @@ -25,8 +25,10 @@ public function doFoo($literalString, string $string)

assertType('string', str_repeat($string, 10));
assertType('literal-string', str_repeat($literalString, 10));
assertType('literal-string', str_repeat('', 10));
assertType('literal-string&non-empty-string', str_repeat('foo', 10));
assertType("''", str_repeat('', 10));
assertType("'foofoofoofoofoofoofoofoofoofoo'", str_repeat('foo', 10));
assertType("'?,?,?,'", str_repeat('?,', 3));
assertType("*NEVER*", str_repeat('?,', -3));

assertType('non-empty-string', str_pad($string, 5, $string));
assertType('non-empty-string', str_pad($literalString, 5, $string));
Expand Down