implemented ConstantStringType inference for str_repeat
#1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clxmstaab
force-pushed
the
str-repeat
branch
2 times, most recently
from
ed665c1
to
14b954c
Compare
clxmstaab
force-pushed
the
str-repeat
branch
from
14b954c
to
954e089
Compare
ondrejmirtes
requested changes
Feb 22, 2022
| @@ -42,6 +42,10 @@ public function getTypeFromFunctionCall( | |||
| return new ConstantStringType(''); | |||
| } | |||
|
|
|||
| if ($inputType instanceof ConstantStringType && $multiplierType instanceof ConstantIntegerType) { | |||
| return new ConstantStringType(str_repeat($inputType->getValue(), $multiplierType->getValue())); | |||
There was a problem hiding this comment.
The code will crash when analysing code like this: https://3v4l.org/XRaOj
There was a problem hiding this comment.
good point. added a test and made it return NeverType on negative multiplier
clxmstaab
force-pushed
the
str-repeat
branch
from
dd3af96
to
e3df0c3
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#6679