Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type specification of subtractable types #1028

Merged
merged 2 commits into from Feb 22, 2022
Merged

Improve type specification of subtractable types #1028

merged 2 commits into from Feb 22, 2022

Commits on Feb 21, 2022

  1. Improve SpecifiedTypes::inverse 

    The previous assumption was incorrect, it is not enough to just swap the sureTypes and sureNotTypes, as this can easily lead to a NeverType.
In this change a SubtractableType is created instead for both which makes retains more type information in follow-up operations like union or intersect.
    @herndlm
    herndlm committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    522af3e View commit details
    Browse the repository at this point in the history

  2. Improve intersect and union of SubtractableTypes 

    Converts non-SubtractableTypes to SubtractableTypes in union to not loose subtracted type information.
Sorts the SubtractableTypes in intersect to not loose subtracted type information if SubtractableTypes are intersected where not all of them have subtracted types configured.
    @herndlm
    herndlm committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    2237c47 View commit details
    Browse the repository at this point in the history