Improve type specification of subtractable types #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous assumption was incorrect, it is not enough to just swap the sureTypes and sureNotTypes, as this can easily lead to a NeverType. In this change a SubtractableType is created instead for both which makes retains more type information in follow-up operations like union or intersect.
herndlm
force-pushed
the
improve-type-specification-of-subtractable-types
branch
from
1ab2878
to
7438b86
Compare
Converts non-SubtractableTypes to SubtractableTypes in union to not loose subtracted type information. Sorts the SubtractableTypes in intersect to not loose subtracted type information if SubtractableTypes are intersected where not all of them have subtracted types configured.
herndlm
force-pushed
the
improve-type-specification-of-subtractable-types
branch
from
7438b86
to
2237c47
Compare
staabm
reviewed
Feb 22, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#6672
Related to phpstan/phpstan#6674
Not quite happy yet about the sorting, I feel there is a better way to handle this, somehow in the loop maybe, but I can't wrap my head around it right now.