Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary operations on non-empty-string and string should error #1010

Merged
merged 12 commits into from Feb 10, 2022
Merged

Binary operations on non-empty-string and string should error #1010

merged 12 commits into from Feb 10, 2022

Commits on Feb 10, 2022

  1. added failling test

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    9cf410c View commit details
    Browse the repository at this point in the history

  2. more testcoverage

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    16dc449 View commit details
    Browse the repository at this point in the history

  3. more testcoverage

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    5e3f7b3 View commit details
    Browse the repository at this point in the history

  4. type inference coverage

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    3475dce View commit details
    Browse the repository at this point in the history

  5. fix

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    da0c5bd View commit details
    Browse the repository at this point in the history

  6. fix cs

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    9555553 View commit details
    Browse the repository at this point in the history

  7. literal-strings should not error

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    601f646 View commit details
    Browse the repository at this point in the history

  8. added Type->isString()

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    726e389 View commit details
    Browse the repository at this point in the history

  9. fix

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    47f8484 View commit details
    Browse the repository at this point in the history

  10. more testcoverage

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    6b5f089 View commit details
    Browse the repository at this point in the history

  11. more testcoverage. simplify fix

    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    5766931 View commit details
    Browse the repository at this point in the history

  12. removed comment 

    initially I had a different assumption what this method would provide
    @clxmstaab
    clxmstaab committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    e2341fb View commit details
    Browse the repository at this point in the history