Binary operations on non-empty-string and string should error
#1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The right solution here is to introduce |
hmm do you mean adding this method on the |
|
It's not a BC break, implementing custom Type isn't covered by BC promise. |
|
I see. I got the impression because the
|
ondrejmirtes
requested changes
Feb 10, 2022
src/Analyser/MutatingScope.php
Outdated
| @@ -1419,6 +1424,12 @@ private function resolveType(Expr $node): Type | |||
|
|
|||
| $resultType = TypeCombinator::union($leftNumberType, $rightNumberType); | |||
| if ($node instanceof Expr\AssignOp\Div || $node instanceof Expr\BinaryOp\Div) { | |||
| // division on strings is not allowed. its allowed on numeric strings though. | |||
| if ($leftType->isString()->yes() && !$leftType->isNumericString()->yes() && !$leftType->isLiteralString()->yes() | |||
| || $rightType->isString()->yes() && !$rightType->isNumericString()->yes() && !$rightType->isLiteralString()->yes()) { | |||
There was a problem hiding this comment.
||vs.&&operator priority needs to be disambiguated with parentheses- I don't know why literal-string is mentioned in this condition
There was a problem hiding this comment.
- fixed
- I mixed up my mental model in "123" would be a literal-string, but it is also a numeric-string, so the additional check is not necessary. fixed a bug so we don't accept
literal-stringfor binary operations
src/Analyser/MutatingScope.php
Outdated
| @@ -1400,6 +1400,11 @@ private function resolveType(Expr $node): Type | |||
| return new ErrorType(); | |||
| } | |||
|
|
|||
| if ($leftType->isNonEmptyString()->yes() && !$leftType->isNumericString()->yes() || | |||
There was a problem hiding this comment.
||vs.&&operator priority needs to be disambiguated with parentheses- Why
isNonEmptyStringand notisString?
There was a problem hiding this comment.
- fixed
- I used
non-empty-stringbecause the initial bug report was about non-emptry-string problems, while it already worked for regularstring.
I am now usingisStringinstead ofisNonEmptyStringin the first block, which renders this second block of changes unnecessary. I removed it.
initially I had a different assumption what this method would provide
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#6624