Fix comparison with get_class() in traits always evaluate to true

src/Type/Php/GetClassDynamicReturnTypeExtension.php

@@ -17,6 +17,7 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\ObjectWithoutClassType;
 use PHPStan\Type\StaticType;
+use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeTraverser;
 use PHPStan\Type\TypeWithClassName;
@@ -34,6 +35,7 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
 	public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
 	{
 		$args = $functionCall->getArgs();
+
 		if (count($args) === 0) {
 			if ($scope->isInClass()) {
 				return new ConstantStringType($scope->getClassReflection()->getName(), true);
@@ -42,6 +44,10 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 			return new ConstantBooleanType(false);
 		}
 
+		if ($scope->isInTrait()) {
+			return new StringType();
+		}
+
 		$argType = $scope->getType($args[0]->value);
 
 		return TypeTraverser::map(

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -613,4 +613,10 @@ public function testPhpUnitIntegration(): void
 		$this->analyse([__DIR__ . '/../../Analyser/data/phpunit-integration.php'], []);
 	}
 
+	public function testBug3633(): void
+	{
+		$this->checkAlwaysTrueStrictComparison = true;
+		$this->analyse([__DIR__ . '/data/bug-3633.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-3633.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types = 1);
+
+namespace Bug3633;
+
+trait Foo {
+	public function test(): void {
+		if (get_class($this) === HelloWorld::class) {
+			echo "OK";
+		}
+		if (get_class($this) === OtherClass::class) {
+			echo "OK";
+		}
+	}
+}
+
+class HelloWorld {
+	use Foo;
+
+	public function bar(): void {
+		$this->test();
+	}
+}
+
+class OtherClass {
+	use Foo;
+
+	public function bar(): void {
+		$this->test();
+	}
+}