Non-static method DOMDocument::loadHTML() can be called statically

phpstan · Dec 4, 2022 · 66dc2ad · 66dc2ad
1 parent 0f1bfb5
commit 66dc2ad
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Rules/Methods/StaticMethodCallCheck.php b/src/Rules/Methods/StaticMethodCallCheck.php
@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Methods;
 
+use DOMDocument;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\NullsafeOperatorHelper;
@@ -224,6 +225,11 @@ public function check(
 					&& !$scope->getClassReflection()->isSubclassOf($classType->getClassName())
 				)
 			) {
+				// per php-src docs, this method can be called statically, even if declared non-static
+				if (strtolower($method->getName()) === 'loadhtml' && $method->getDeclaringClass()->getName() === DOMDocument::class) {
+					return [[], null];
+				}
+
 				return [
 					array_merge($errors, [
 						RuleErrorBuilder::message(sprintf(

diff --git a/tests/PHPStan/Rules/Methods/data/call-static-methods.php b/tests/PHPStan/Rules/Methods/data/call-static-methods.php
@@ -345,3 +345,11 @@ public function doBar()
 	}
 
 }
+
+class Bug2759 {
+	public function sayHello(string $html): void
+	{
+		$dom = \DOMDocument::loadHTML($html, LIBXML_NOWARNING | LIBXML_NONET | LIBXML_NOERROR);
+	}
+}
+