use ExpressionTypeHolder when comparing conditionals

phpstan · Dec 5, 2022 · ec31e41 · ec31e41
1 parent 66dc2ad
commit ec31e41
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -3731,13 +3731,13 @@ public function filterBySpecifiedTypes(SpecifiedTypes $specifiedTypes): self
 			} else {
 				$scope = $scope->removeTypeFromExpression($expr, $type);
 			}
-			$specifiedExpressions[$this->getNodeKey($expr)] = $scope->getType($expr);
+			$specifiedExpressions[$this->getNodeKey($expr)] = ExpressionTypeHolder::createYes($expr, $scope->getType($expr));
 		}
 
 		foreach ($scope->conditionalExpressions as $conditionalExprString => $conditionalExpressions) {
 			foreach (array_reverse($conditionalExpressions) as $conditionalExpression) {
 				foreach ($conditionalExpression->getConditionExpressionTypeHolders() as $holderExprString => $conditionalTypeHolder) {
-					if (!array_key_exists($holderExprString, $specifiedExpressions) || !$specifiedExpressions[$holderExprString]->equals($conditionalTypeHolder->getType())) {
+					if (!array_key_exists($holderExprString, $specifiedExpressions) || !$specifiedExpressions[$holderExprString]->equals($conditionalTypeHolder)) {
 						continue 2;
 					}
 				}
@@ -3746,7 +3746,7 @@ public function filterBySpecifiedTypes(SpecifiedTypes $specifiedTypes): self
 					unset($scope->expressionTypes[$conditionalExprString]);
 				} else {
 					$scope->expressionTypes[$conditionalExprString] = $conditionalExpression->getTypeHolder();
-					$specifiedExpressions[$conditionalExprString] = $conditionalExpression->getTypeHolder()->getType();
+					$specifiedExpressions[$conditionalExprString] = $conditionalExpression->getTypeHolder();
 				}
 				continue 2;
 			}