Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation notice on dynamic property (PHP 8.2) #1435

Merged
merged 1 commit into from Dec 12, 2022

Conversation

gquemener
Copy link
Contributor

This is the only issue I've ran into while running the test suite on PHP 8.2.

@rvanlaak
Copy link

Would be great to get this merged! Any plans on thereafter supporting 8.2 on the composer.json as well? That would allow MoneyPHP to thereafter support 8.2 as well.

@gquemener
Copy link
Contributor Author

There's a circular dependency between phpspec and prophecy that prevents CI pipelines to run on 8.2.

I would advise to merge prophecy first, but I let you decide on the best strategy here @ciaranmcnulty :)

@gquemener
Copy link
Contributor Author

FYI, I have updated both pipeline config to run against 8.2, as well as increasing php support range in composer.json.

@andypost
Copy link

andypost commented Oct 20, 2022

I think it makes sense to commit as bugfix to allow more people to install it, maybe CI can add --ignore-platform-req=php while phpspec/prophecy/labels/PHP8.2 is not allowed to install dependency

@mkoprek
Copy link

mkoprek commented Dec 9, 2022

Dependencies are resolved (phpspec/prophecy#571), can some one try to ryn pipelines again?

@internalsystemerror
Copy link

@gquemener Are you able to retrigger CI? Or does it need a maintainer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants