Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for php 8.2 #689

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Add support for php 8.2 #689

merged 1 commit into from
Apr 17, 2023

Conversation

xelaris
Copy link

@xelaris xelaris commented Dec 9, 2022

See phpspec/phpspec#1435 for a similar update and for the reason why ci isn't successfully yet, as phpspec does't support 8.2 yet.

@Nek-
Copy link
Contributor

Nek- commented Dec 12, 2022

Sorry but this is not enough for making Gaufrette compatible with PHP 8.2. IIRC the stream integration is not working anymore.

@xelaris
Copy link
Author

xelaris commented Dec 12, 2022

@Nek- thank you for the quick feedback.

We are using the stream integration in our project. Actually, the reason for this PR is, that the StreamWrapper causes the deprecation about the dynamic $context property, which is (wrongly?) considered a direct deprecation by the Symfony PHPUnit bridge.

I found #275, which mentions some issues. In our simple use-case (file_put_contents with AWS S3 adapter) it seems to work fine though.

Do you have any guidance about what else needs to be done to get Gaufrette compatible with PHP 8.2? I might find the time to have a look at it.

In any case, I guess this PR has to wait for release of phpspec which is compatible with PHP 8.2 for all tests become green eventually. Or do you think this PR should be updated to temporarily require phpspec/phpspec: "dev-main@dev"?

@toooni
Copy link

toooni commented Feb 21, 2023

Is there still a reason to not merge this PR? Except for these deprecation messages, our use case works fine on PHP 8.2.

@PedroTroller PedroTroller changed the base branch from master to v0.12.0 April 17, 2023 12:14
@PedroTroller PedroTroller marked this pull request as ready for review April 17, 2023 12:14
@PedroTroller PedroTroller merged commit ddfda44 into KnpLabs:v0.12.0 Apr 17, 2023
@PedroTroller
Copy link
Member

Thank you very much. I took the liberty of validating your PR which remained in draft. We'll put your PR in the next version, v0.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants