Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-7910: rename fails on Windows if the target is being executed #9351

Draft
wants to merge 2 commits into
base: PHP-8.1
Choose a base branch
from
Draft

Fix GH-7910: rename fails on Windows if the target is being executed #9351

wants to merge 2 commits into from

Commits on Sep 6, 2022

  1. Fix phpGH-7910: rename fails on Windows if the target is being executed 

    Prior to commit c732ab4[1], the script file was closed immediately
after compilation, but the destruction has been properly moved to the
initialization side.  Still, at least closing the stream needs to be
done right after compilation to avoid too many open file handles (e.g.
`php -F`), and to avoid some limitations on Windows.  Thus, we
introduce `zend_stream_close()` which only closes the stream, and is
called from `zend_file_handle_dtor()`.

[1] <php@c732ab4>
    @cmb69
    cmb69 committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c7f24d9 View commit details
    Browse the repository at this point in the history

  2. Only close handle streams which have been opened by zend_stream_fixup()

    @cmb69
    cmb69 committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0b148ea View commit details
    Browse the repository at this point in the history