Fix GH-7910: rename fails on Windows if the target is being executed #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to commit c732ab4[1], the script file was closed immediately after compilation, but the destruction has been properly moved to the initialization side. Still, at least closing the stream needs to be done right after compilation to avoid too many open file handles (e.g. `php -F`), and to avoid some limitations on Windows. Thus, we introduce `zend_stream_close()` which only closes the stream, and is called from `zend_file_handle_dtor()`. [1] <php@c732ab4>
|
Friendly bump, this issue is being reported again on Symfony, see symfony/symfony#50326 |
|
Also, on the Windows platform, self-upgrade in Grav CMS is broken. Because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to commit c732ab4[1], the script file was closed immediately
after compilation, but the destruction has been properly moved to the
initialization side. Still, at least closing the stream needs to be
done right after compilation to avoid too many open file handles (e.g.
php -F), and to avoid some limitations on Windows. Thus, weintroduce
zend_stream_close()which only closes the stream, and iscalled from
zend_file_handle_dtor().[1] c732ab4