Fix stream wrapper (tweaked #193) #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the stream_* methods some clients expect that there is an internal key of `headers`. By emulating this key VCR can be compatible with more clients. I encountered this issue when trying to use VCR with the CakePHP HTTP Client which uses the stream API.
|
Thanks @snelg 👏 |
Closed
Closed
|
What should we do to get this code in master and a new tag ? |
|
Hi there - is there any plans if this fix would go into master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Tweaked version of #193 to pass all tests and Travis builds
What has been done
Notes
See #193 for other details