Fix stream emulation #193
Closed
Fix stream emulation #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WSDL files from cdyne.com are no longer available. Because this service is offline the quickest way to get a passing test run was to skip some tests.
When using the stream_* methods some clients expect that there is an internal key of `headers`. By emulating this key VCR can be compatible with more clients. I encountered this issue when trying to use VCR with the CakePHP HTTP Client which uses the stream API.
|
Closing as #230 incorporates these changes with test fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Stream API emulation is incomplete, because
headerscannot be accessed out of the wrapper data so client code that works with native streams + curlwrappers fails when emulated by VCR.What has been done
headerskey which is populated by the nativehttpandhttpsstream implementations when PHP is compiled with curlwrappers support (the default on osx)How to test
Todo
N/A
Notes
N/A