Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Date.iso8601 function to calculate start and end date for the generated certificate #5738

Merged

Conversation

quitejonny
Copy link
Contributor

Use Date.iso8601 function instead of custom implementation to calculate start and end date for the generated certificate

…te start and end date for the generated certificate
Copy link
Contributor

@rud rud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good plan

@josevalim josevalim merged commit 560d2ae into phoenixframework:main Mar 10, 2024
5 of 6 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@quitejonny quitejonny deleted the phx-gen-cert-refactoring branch March 11, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants