Generate certificate with a valid end date on a February 29 #5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️❤️❤️🐥🔥 |
wojtekmach
reviewed
Feb 29, 2024
| mm = month |> Integer.to_string() |> String.pad_leading(2, "0") | ||
| dd = day |> Integer.to_string() |> String.pad_leading(2, "0") | ||
|
|
||
| yy <> mm <> dd |
There was a problem hiding this comment.
@quitejonny you can also use Date.to_iso8601(date, :basic) which does all of the above. Then I don’t think we need this helper function. :) could you send another patch?
There was a problem hiding this comment.
I opened a new PR #5738 which uses the Date.to_iso8601 function instead of a custom implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We could not generate a certificate with phx.gen.cert today because of an invalid end date.
With a starting date of 2024-02-29 the task would generate an invalid end date of 2025-02-29.
Solution
This PR fixes this bug by calculating an end 365 days in the future.