Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FeatureRepository::remove contract to accept Feature instead of FeatureId #30

Closed
xserrat opened this issue Oct 6, 2021 · 0 comments · Fixed by #31
Closed

Update FeatureRepository::remove contract to accept Feature instead of FeatureId #30

xserrat opened this issue Oct 6, 2021 · 0 comments · Fixed by #31
Assignees
@xserrat
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues

Comments

@xserrat
Copy link
Contributor

xserrat commented Oct 6, 2021

Epic: pheature-flags/pheature-flags#309

We need to update the FeatureRepository::remove contract to accept Feature instead of FeatureId:

public function remove(Feature $feature): void
@xserrat xserrat added enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Oct 6, 2021
This was referenced Oct 6, 2021
Closed
Closed
Closed
@xserrat xserrat self-assigned this Oct 6, 2021
xserrat added a commit that referenced this issue Oct 6, 2021
@xserrat
[#30] Update FeatureRepository::remove contract to accept Feature ins…
2716fd9 
…tead of FeatureId
@xserrat xserrat mentioned this issue Oct 6, 2021
Merged
xserrat added a commit that referenced this issue Oct 7, 2021
@xserrat
[#30] Update FeatureRepository::remove contract to accept Feature ins…
909814d 
…tead of FeatureId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xserrat xserrat

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
1 participant
@xserrat