Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update InMemoryFeatureRepository::remove contract with a Feature instead of FeatureId #4

Closed
xserrat opened this issue Oct 6, 2021 · 0 comments · Fixed by #5
Closed

Update InMemoryFeatureRepository::remove contract with a Feature instead of FeatureId #4

xserrat opened this issue Oct 6, 2021 · 0 comments · Fixed by #5
Assignees
@xserrat
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues

Comments

@xserrat
Copy link
Contributor

xserrat commented Oct 6, 2021

Epic: pheature-flags/pheature-flags#309
Depends on: pheature-flags/toggle-core#30

We need to accept a Feature entity instead of a FeatureId:

public function remove(Feature $feature): void
@xserrat xserrat added enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Oct 6, 2021
@xserrat xserrat mentioned this issue Oct 6, 2021
Closed
@xserrat xserrat changed the title Update InMemoryFeatureRepository::remove contract with a Feature instead of FeatureId Update InMemoryFeatureRepository::remove contract with a Feature instead of FeatureId Oct 6, 2021
@xserrat xserrat self-assigned this Oct 6, 2021
xserrat added a commit that referenced this issue Oct 6, 2021
@xserrat
[#4] Update InMemoryFeatureRepository::remove contract with a Feature…
a3af9ef 
… instead of FeatureId
xserrat added a commit that referenced this issue Oct 6, 2021
@xserrat
[#4] Remove docker from grumphp
9d18e29
@xserrat xserrat mentioned this issue Oct 6, 2021
Merged
xserrat added a commit that referenced this issue Oct 8, 2021
@xserrat
[#4] Upgrade "pheature/toggle-core" and "pheature/toggle-model" to ve…
f85a847 
…rsion ^0.2
@xserrat xserrat closed this as completed in #5 Oct 8, 2021
xserrat added a commit that referenced this issue Oct 8, 2021
@xserrat
[#4] Update InMemoryFeatureRepository::remove contract with a Feature…
aa01df1 
… instead of FeatureId
xserrat added a commit that referenced this issue Oct 8, 2021
@xserrat
[#4] Remove docker from grumphp
f7d8a2d
xserrat added a commit that referenced this issue Oct 8, 2021
@xserrat
[#4] Upgrade "pheature/toggle-core" and "pheature/toggle-model" to ve…
9f7459c 
…rsion ^0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xserrat xserrat

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
1 participant
@xserrat