[#4] Update InMemoryFeatureRepository::remove contract with a Feature…

… instead of FeatureId
pheature-flags · Oct 8, 2021 · aa01df1 · aa01df1
1 parent ffe3c26
commit aa01df1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/InMemoryFeatureRepository.php b/src/InMemoryFeatureRepository.php
@@ -18,9 +18,9 @@ public function save(Feature $feature): void
         $this->features[$feature->id()] = $feature;
     }
 
-    public function remove(FeatureId $featureId): void
+    public function remove(Feature $feature): void
     {
-        unset($this->features[$featureId->value()]);
+        unset($this->features[$feature->id()]);
     }
 
     public function get(FeatureId $featureId): Feature

diff --git a/test/InMemoryFeatureRepositoryTest.php b/test/InMemoryFeatureRepositoryTest.php
@@ -40,7 +40,7 @@ public function testItShouldRemoveSavedFeatureAtInMemoryRepository(): void
         $repository = new InMemoryFeatureRepository();
         $repository->save($feature);
         self::assertSame($feature, $repository->get($featureId));
-        $repository->remove($featureId);
+        $repository->remove($feature);
         $repository->get($featureId);
     }
 }