Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getProcedures returns only procedures (not functions) for psql11+ #1723

Merged
merged 4 commits into from Feb 27, 2020
Merged

fix: getProcedures returns only procedures (not functions) for psql11+ #1723

merged 4 commits into from Feb 27, 2020

Commits on Feb 27, 2020

  1. fix: getProcedures returns only procedures (not functions) for psql11+ 

    Currently the PGDatabaseMetaData.getProcedures() method returns both
procedures and functions. This made sense prior to PostgreSQL11, but now
actual procedures can be created instead of just functions, and pgjdbc
has an added getFunctions() method to distinguish between the two. For
only PostgreSQL version 11 and onward, this will make getFunctions()
return only functions and getProcedures() return only procedures.

I believe this closes pgjdbc#1340 and pgjdbc#1629, which both seem to essentially be
the same thing?
    @MSGoodman
    MSGoodman committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    3302285 View commit details
    Browse the repository at this point in the history

  2. only create procedure in tests for psql versions 11 and higher

    @MSGoodman
    MSGoodman committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    c7bc127 View commit details
    Browse the repository at this point in the history

  3. testGetProcedures now checks for functions or procedures depending on… 

    … psql version
    @MSGoodman
    MSGoodman committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    17d5b87 View commit details
    Browse the repository at this point in the history

  4. only test 'create procedure' for psql 11+

    @MSGoodman
    MSGoodman committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    5fc0893 View commit details
    Browse the repository at this point in the history