fix: getProcedures returns only procedures (not functions) for psql11+ #1723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
PGDatabaseMetaData.getProcedures()
method returns bothprocedures and functions. This made sense prior to PostgreSQL11, but now
actual procedures can be created instead of just functions, and pgjdbc
has an added
getFunctions()
method to distinguish between the two. Foronly PostgreSQL version 11 and onward, this will make
getFunctions()
return only functions and
getProcedures()
return only procedures.I believe this closes #1340 and closes #1629, which both seem to essentially be
the same thing?
All Submissions:
Changes to Existing Features:
I am unsure if this should be considered breaking. Since PostgreSQL 11 has been out since 2018, I assume there is some code out there relying on the assumption that
getProcedures()
returns both functions and procedures rather than just procedures. ¯\(ツ)/¯