Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added http request grammar #726

Merged
merged 1 commit into from Oct 25, 2022

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Oct 21, 2022

plus tests, benchmark and a fuzzing target

based on #372 by @adamAndMath

@tomtau tomtau requested a review from a team October 21, 2022 14:06
@tomtau tomtau requested a review from a team as a code owner October 21, 2022 14:06
@tomtau tomtau requested review from NoahTheDuke and removed request for a team October 21, 2022 14:06
@tomtau tomtau linked an issue Oct 21, 2022 that may be closed by this pull request
@tomtau tomtau mentioned this pull request Oct 21, 2022
@tomtau
Copy link
Contributor Author

tomtau commented Oct 21, 2022

(note that the grammar is a bit more permissive than it should be, but probably ok for this sample grammar testing or it could be refined in a follow up PR)

plus tests, benchmark and a fuzzing target

based on pest-parser#372 by @adamAndMath

Closes pest-parser#210

Co-authored-by: Adam <adam.and.math@gmail.com>
Copy link
Member

@NoahTheDuke NoahTheDuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think 100% accuracy is needed for fuzzing targets, and we can tighten it up later down the road.

@tomtau tomtau merged commit 683a7e7 into pest-parser:master Oct 25, 2022
@tomtau tomtau deleted the feature/httpreq branch October 25, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an HTTP parser to parser_benchmarks
2 participants