Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an HTTP parser to parser_benchmarks #210

Closed
Geal opened this issue Mar 23, 2018 · 1 comment · Fixed by #726
Closed

Add an HTTP parser to parser_benchmarks #210

Geal opened this issue Mar 23, 2018 · 1 comment · Fixed by #726

Comments

@Geal
Copy link

Geal commented Mar 23, 2018

Hello!

I spent some time cleaning up the old nom_benchmarks repository in a more general parser_benchmarks. Since we're reaching the point where the various parser libraries reach the same performance, it's getting interesting to have a good way to compare them on the same tests, and transfer techniques from one to the next.

I have added your JSON example and put it to work on the other example files (and added the canada.json file you use for your benchmarks): https://github.com/Geal/parser_benchmarks/tree/master/json

Interestingly, I have not been able to make the nom parser faster than the pest one for that file :)

Could you check the benchmark to see if I have not missed anything in how to use pest?
Also, do you think you could contribute a HTTP parser to the repository?

@dragostis
Copy link
Contributor

dragostis commented Mar 23, 2018

Nice work with the benchmark and thank you for taking the time to do this. 😄

Everything looks good. You might also want to compare pest against the master branch since there are some performance improvements coming up in the next version.

Regarding the HTTP benchmark, this would have a lower priority for now. We're currently working a lot on improving the developer experience and the docs which is quite harder than I first thought.

EDIT: I've checked the other benchmarks. Congrats on the performance gains!

@jstnlef jstnlef changed the title benchmarks verification Add an HTTP parser to parser_benchmarks Apr 28, 2018
tomtau pushed a commit to tomtau/pest that referenced this issue Oct 21, 2022
plus tests, benchmark and a fuzzing target

based on pest-parser#372 by @adamAndMath

Closes pest-parser#210

Co-authored-by: Adam <adam.and.math@gmail.com>
@tomtau tomtau linked a pull request Oct 21, 2022 that will close this issue
tomtau pushed a commit to tomtau/pest that referenced this issue Oct 21, 2022
plus tests, benchmark and a fuzzing target

based on pest-parser#372 by @adamAndMath

Closes pest-parser#210

Co-authored-by: Adam <adam.and.math@gmail.com>
tomtau added a commit that referenced this issue Oct 25, 2022
plus tests, benchmark and a fuzzing target

based on #372 by @adamAndMath

Closes #210

Co-authored-by: Adam <adam.and.math@gmail.com>

Co-authored-by: Tomas Tauber <me@tomtau.be>
Co-authored-by: Adam <adam.and.math@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants