Adding HTTP grammar #372
Closed
Adding HTTP grammar #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This looks good to me, but I don't know the grammar well enough. Anyone interested to review this? |
tomtau
pushed a commit
to tomtau/pest
that referenced
this pull request
Oct 21, 2022
plus tests, benchmark and a fuzzing target based on pest-parser#372 by @adamAndMath Co-authored-by: Adam <adam.and.math@gmail.com>
tomtau
pushed a commit
to tomtau/pest
that referenced
this pull request
Oct 21, 2022
plus tests, benchmark and a fuzzing target based on pest-parser#372 by @adamAndMath Closes pest-parser#210 Co-authored-by: Adam <adam.and.math@gmail.com>
|
I dusted off this PR in #726 |
tomtau
pushed a commit
to tomtau/pest
that referenced
this pull request
Oct 21, 2022
plus tests, benchmark and a fuzzing target based on pest-parser#372 by @adamAndMath Closes pest-parser#210 Co-authored-by: Adam <adam.and.math@gmail.com>
tomtau
added a commit
that referenced
this pull request
Oct 25, 2022
plus tests, benchmark and a fuzzing target based on #372 by @adamAndMath Closes #210 Co-authored-by: Adam <adam.and.math@gmail.com> Co-authored-by: Tomas Tauber <me@tomtau.be> Co-authored-by: Adam <adam.and.math@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to make a http request grammar file, as mentioned in #210. It doen't restrict the allowed characters in tokens as much as they should be, as I don't know how to properly express the range of allowed characters.
It is currently untested as I don't have much experience with the format, and don't quite know what I should and shouldn't test.