New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when target
(in Value.preserveToString) is undefined
#470
Conversation
Update master branch
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 2 2
Lines 2352 2352
Branches 607 607
=======================================
Hits 2024 2024
Misses 328 328
Continue to review full report at Codecov.
|
target
Value.preserveToString is undefined in WSH with babel-polyfill
target
Value.preserveToString is undefined in WSH with babel-polyfilltarget
(in Value.preserveToString) is undefined in WSH with babel-polyfill
target
(in Value.preserveToString) is undefined in WSH with babel-polyfilltarget
(in Value.preserveToString) is undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like with the previous change, I would much prefer to locate the specific caller of ES.preserveToString
rather than papering over the problem here.
This means that How can I fix a problem that |
Ah - if |
Found a better solution. |
* Reverted from paulmillr#466 - No need to check that this is 'undefined'. * This pull request fix the following issue: paulmillr#470 paulmillr#467
#467