Fix ReflectShims.defineProperty is undefined in WSH
#471
Conversation
Update master branch
* Reverted from paulmillr#466 - No need to check that this is 'undefined'. * This pull request fix the following issue: paulmillr#470 paulmillr#467
| if (supportsDescriptors) { | ||
| if (!ReflectShims.defineProperty) { // possible alternative: if (supportsDescriptors) |
There was a problem hiding this comment.
supportsDescriptors is only true when get/set are available - but ReflectShims.defineProperty might be available in the same way Object.defineProperty might be - working fine for enumerable/configurable/writable data properties, but throwing for everything else. What does this fix?
There was a problem hiding this comment.
This change is a key point to solve #466 and other overrideNative related crash issues.
In WSH(polyfilled by core-js), supportsDescriptors(es6-shim) is false bacause of if(!supportsAccessors && (hasGetter || hasSetter))(es5-shim) is true.
Because of this, replacement parameter is undefined when calling overrideNative. This causes the wrong override.
There was a problem hiding this comment.
This part should be run regardless of the values in supportsDescriptors.
There was a problem hiding this comment.
I'm still a bit unclear on your explanation.
If you're in WSH, polyfilled by core-js, why are you running es5-shim and es6-shim at all? You're supposed to use core-js OR es-shims, not both.
|
Any update? |
|
I'll open it again when the issue becomes clear. |
|
I’d love to understand what’s going on - do issues appear when not using core-js? |
undefined.target(in Value.preserveToString) is undefined #470 babel-polyfill and es6-shim #467