Experimental REPL PoC #136
Conversation
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 87.85% 87.73% -0.13%
==========================================
Files 20 20
Lines 2257 2258 +1
==========================================
- Hits 1983 1981 -2
- Misses 274 277 +3
Continue to review full report at Codecov.
|
| .iter() | ||
| .any(|err| matches!(err, ParseError::UnexpectedEndOfInput)) | ||
| { | ||
| Ok(ValidationResult::Incomplete) |
There was a problem hiding this comment.
From couple errors I've seen, this can be as a result of incomplete Grammar, do we want to provide some hints or perhaps link for cutting an issue if the input appears to be correct. For example before this PR we were getting UnexpectedEndOfInput for SELECT * FROM a AS a CROSS JOIN c AS c AT q.
There was a problem hiding this comment.
I'm sure to bring this out of PoC we will need something more robust here. For now, this is what allows you to do things like hit <ENTER> and continue writing the query on the next line in the middle of a query.
There was a problem hiding this comment.
That's fair, maybe as a follow-on we can add a README to emphasize on the PoC.
There was a problem hiding this comment.
+1 a short README would be helpful.
There was a problem hiding this comment.
added minimal README
jpschorr
force-pushed
the
spike-cli
branch
2 times, most recently
from
ed0726d
to
ce91826
Compare
| @@ -0,0 +1,131 @@ | |||
| %YAML 1.2 | |||
There was a problem hiding this comment.
I'm curious if there a better place to store these syntax files so they could be used by other programs. Is there a way to publish the sublime syntaxes (i.e. partiql.sublime-syntax and ion.sublime-syntax) somewhere similar to what you had done for the ACE editor (ajaxorg/ace#4630)? Alternatively, we could have a separate repo for the syntax highlighting modes that could be taken as a submodule of this repo.
There was a problem hiding this comment.
Yes. We should likely have all the tooling somewhere else and bring it in via submodule or something else here. The official way add a sublime extension is via https://packagecontrol.io/docs/submitting_a_package
| .iter() | ||
| .any(|err| matches!(err, ParseError::UnexpectedEndOfInput)) | ||
| { | ||
| Ok(ValidationResult::Incomplete) |
There was a problem hiding this comment.
+1 a short README would be helpful.
This is a minimal PoC for the start of a REPL. It should be considered experimental, subject to change, etc.
I wrote this in order to test the parser interface & types from the perspective of an external application. As a result, some minor tweaks were made around error reporting. Potentially a refactor of the mietter::Diagnostic stuff in this PR will be included in the parser crate in the future.
It currently accepts no commands, assuming any/all input is a PartiQL query, which it will attempt to parse. Parse errors are pretty printed to the output.
This uses:
ionandpartiqlsyntax definitionsDemo:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.