New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds syntax highlighting to the CLI #639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some really nice work here! Syntax highlighting would definitely be a great feature to add for the PartiQL REPL experience.
Left some questions about the syntax highlighting support from JLine (and if we're restricted to just nanorc
files) and additional documentation.
e0411cf
to
0814018
Compare
Decided to go ahead and use the SqlLexer and SqlParser instead of the nanorc files because nanorc doesn't allow advanced features such as multiple grammars (hence our inability to differentiate between PartiQL quoted identifiers and Ion strings). Makes the most sense to use our grammar to identify tokens. I've updated the description with a new video. Later, we can add highlighting for Ion, and this sets us up for that. |
Relevant Issue
None.
Description
--monochrome
or-m
on the REPL to avoid using syntax highlightingPreview below:
partiql-cli-new.mov
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.