Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-override for Shell Highlighter #645

Open
johnedquinn opened this issue Jun 21, 2022 · 1 comment
Open

Add color-override for Shell Highlighter #645

johnedquinn opened this issue Jun 21, 2022 · 1 comment

Comments

@johnedquinn
Copy link
Member

May be useful to abstract the Token styling to a separate configuration a user can modify and provide through the ShellConfiguration. For accessibility (e.g. color-blindness), it may be helpful for a user to modify the Token styling to something other than the defaults. Feel free to create an issue to track since that configurability may be out of scope for this PR.

Originally posted by @alancai98 in #639 (comment)

@johnedquinn johnedquinn changed the title Add color-override for Shell Syntax Highlighter Add color-override for Shell Highlighter Jun 21, 2022
@johnedquinn
Copy link
Member Author

To give more context, with the new Shell Highlighter, we have the option to remove highlighting using --monochrome, but it would also be nice to provide an override to the colors. Right now, it is programmatic, but we should allow a way to pass in an Ion file to describe the colors of each token type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant