This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Upgrade libp2p to 0.49.0 #12256
Merged
Upgrade libp2p to 0.49.0 #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-markin
added
B0-silent
github-actions
bot
added
the
A3-in_progress
2 tasks
dmitry-markin
force-pushed
the
dm-upgrade-libp2p-to-0.48.0
branch
from
17309e9
to
8770e13
Compare
dmitry-markin
force-pushed
the
dm-upgrade-libp2p-to-0.48.0
branch
from
8770e13
to
f521361
Compare
dmitry-markin
changed the title
3 tasks
melekes
reviewed
Sep 22, 2022
|
This upgrade also removes an unmaintained dependency from being pulled in (a few levels down) so I would love to see this landed. |
@melekes There is a blocking bug in libp2p-0.48 with |
|
Once we've done this PR, we should do another PR to bump kvdb-rocksdb to 0.16 (like https://github.com/paritytech/substrate/pull/11144/files ) as the current version is also dependent on the unmaintained crate. That second PR should reduce the pulling in of multiple crate versions that this PR will create. (feel free to ping me to do it if you don't want to, just want to make sure it gets done.) |
|
+1 |
|
Pulled the changes from master in, but still blocked by libp2p-0.49.0 release... |
2 tasks
dmitry-markin
changed the title
github-actions
bot
added
A0-please_review
bkchr
approved these changes
Oct 15, 2022
altonen
approved these changes
Oct 17, 2022
Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com>
dmitry-markin
added
A8-mergeoncegreen
and removed
A0-please_review
|
bot merge |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* cargo upgrade libp2p * Get rid of `NetworkBehaviourEventProcess` in handling of `CustomMessageOutcome` * Get rid of `NetworkBehaviourEventProcess` in handling of `request_responses::Event` * Get rid of `NetworkBehaviourEventProcess` in handling of `peer_info::PeerInfoEvent` * Get rid of `NetworkBehaviourEventProcess` in handling of `DiscoveryOut` * Get rid of `poll()` method in `Bahaviour` * minor: comments * Upgrade libp2p to 0.49.0 (unreleased) * Support multiple Kad protocol names * Make borrow checker happy * minor: wording * Make substrate build with libp2p-0.49.0 * rustfmt * Get rid of MdnsWrapper * Resolve deprecation warnings * Fix documentation * Apply suggestions from code review: fix typos Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com> * Apply suggestion: simplify kad protocol name matching Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12267 and pulls in libp2p/rust-libp2p#2846 to support fallback Kademlia protocol names (see #7746).
The main change is that
NetworkBehaviourEventProcesswas deprecated, so the event processing previously taking place inBehaviourpopped up toNetworkWorker.Follow-Up Issue
Transports and protocols currently used rely on
async-stdprimitives, what can cause issues under thetokioruntime. They should be upgraded to usetokioimplementations: #12499.