Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update libp2p from 0.46.1 to 0.48.0 #12267

Closed
2 tasks done
nbaztec opened this issue Sep 14, 2022 · 2 comments · Fixed by #12256
Closed
2 tasks done

Update libp2p from 0.46.1 to 0.48.0 #12267

nbaztec opened this issue Sep 14, 2022 · 2 comments · Fixed by #12256
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@nbaztec
Copy link

nbaztec commented Sep 14, 2022

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

Substrate currently has libp2p:0.46.1 as one of its dependencies, which via transitivity(libp2p-tcp > if-watch) depends upon windows:0.29.0 which contains a security vulnerability GHSA-x4mq-m75f-mx8m
If updated to the latest libp2p:0.48.0 (minimum 0.47.0), this is fixed. However since there has been a breaking change in libp2p:0.48.0, simply bumping the version isn't enough. Specifically this file breaks with the new Behavior api and I was unable to figure it out.

Perhaps someone from parity can take a look and address a good refactoring strategy?

Steps to reproduce

No response

@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Sep 14, 2022
@bkchr
Copy link
Member

bkchr commented Sep 14, 2022

@dmitry-markin is already working on this.

@dmitry-markin
Copy link
Contributor

Here is the draft PR for reference: #12256

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants