Create gitlab pipeline #534

alvicsam · 2021-10-19T12:32:59Z

Added gitlab pipeline for this repo.

Closes https://github.com/paritytech/ci_cd/issues/240

.gitlab-ci.yml

niklasad1

Thanks alot.

Is the intention to replace all existing Github Actions or just the benches with Gitlab?

I think we need to run the tests too then preferable on Linux, macos and Windows as we do currently.

alvicsam · 2021-10-19T13:57:54Z

Is the intention to replace all existing Github Actions or just the benches with Gitlab?

So initially I was thinking about that because it's easier for CI team to maintain pipelines in one place. But since you have tests on different platforms we have to keep some of the GHA tests for some time

.gitlab-ci.yml

niklasad1 · 2021-10-19T15:15:04Z

So initially I was thinking about that because it's easier for CI team to maintain pipelines in one place. But since you have tests on different platforms we have to keep some of the GHA tests for some time

Ok, then we should probably remove Check and Check style and Benchmarks GHA then....

.gitlab-ci.yml

scripts/ci/pre_cache.sh

.gitlab-ci.yml

dvdplm · 2021-10-22T14:16:31Z

.gitlab-ci.yml

+  stage:                           lint
+  <<:                              *kubernetes-env
+  script:
+    - rustup component add rustfmt


Why isn't the rustfmt component part of the base image? Seems like setting up the toolchain components should be in a single place?

Usually, we run cargo fmt from the nightly release in other repos. I'll add comment here to fix it later.

I see. I guess the question still stands though: wherever you install the nightly toolchain could be a good place to add the rustfmt component as well? And then run cargo +nightly fmt here?

@dvdplm We have nightly fmt installed.
I guess you mean that you're OK with cargo +nightly fmt running here, right?

I'd prefer cargo fmt from stable, but cargo +nightly fmt works too.

it's not a big deal, we can add it to the CI image for stable, too.

I added clippy and fmt to the image however need to wait while issue in substrate is fixed

dvdplm · 2021-10-22T14:16:55Z

.gitlab-ci.yml

+  stage:                           lint
+  <<:                              *docker-env
+  script:
+    - rustup component add clippy


Same concern here.

@dvdplm We have nightly clippy installed.
I guess you mean that you're OK with cargo +nightly clippy --all-targets running here, right?

Same as above, I prefer CI to use stable but yes, I'm ok running nightly clippy too. Curious though, why is clippy not included in the base image?

You mean paritytech/base-ci-linux? It was never requested before to run a stable clippy or fmt.

.gitlab-ci.yml

niklasad1

LGTM,

I'm not convinced about moving clippy to Gitlab though because the Github UI is so nice instead of reading text output from Gitlab.

dvdplm · 2021-10-22T18:23:31Z

I'm not convinced about moving clippy to Gitlab though because the Github UI is so nice instead of reading text output from Gitlab.

I agree with this.

TriplEight · 2021-11-04T18:37:16Z

@dvdplm @niklasad1 can you please point me to what's wrong with GitLab's clippy output

vs a GitHub nice UI's one?

Just the highlighted warnings?

Also note that these are the outputs on the same commit, completely different! Both installed on stable Rust.
Regarding if It's OK to keep clippy in GHA: it then runs on a different version of Rust than the one used by our tested CI image against substrate GitLab. And who knows what do you test in this case.
https://gitlab.parity.io/parity/jsonrpsee/-/jobs/1205035
https://github.com/paritytech/jsonrpsee/runs/4109105358?check_suite_focus=true

TriplEight · 2021-11-04T18:38:34Z

The fact that clippy in GitLab runs 51 sec against 5 sec in GitHub action is due to no cache is used in GitLab for it so far.

niklasad1 · 2021-11-04T20:11:26Z

@dvdplm @niklasad1 can you please point me to what's wrong with GitLab's clippy output

Yes, it's very unlikely that you would click on the individual jobs when reviewing PRs to look at potential lint warnings.
With Github Actions you get warnings inline in the code review which I really like

Such as

Also note that these are the outputs on the same commit, completely different! Both installed on stable Rust.

It's just because the current clippy lint runs cargo clippy and added Gitlab runs cargo clippy --all-targets (including test code and benches)

alvicsam · 2021-11-08T08:29:02Z

@niklasad1 I'm a little bit confused. Was this pr closed accidentally or on purpose?

.gitlab-ci.yml

TriplEight · 2021-11-30T11:59:55Z

.gitlab-ci.yml

+  stage:                           lint
+  <<:                              *kubernetes-env
+  script:
+    - rustup component add rustfmt


@dvdplm We have nightly fmt installed.
I guess you mean that you're OK with cargo +nightly fmt running here, right?

TriplEight · 2021-11-30T12:01:06Z

.gitlab-ci.yml

+  stage:                           lint
+  <<:                              *docker-env
+  script:
+    - rustup component add clippy


@dvdplm We have nightly clippy installed.
I guess you mean that you're OK with cargo +nightly clippy --all-targets running here, right?

TriplEight · 2021-11-30T12:02:39Z

.gitlab-ci.yml

+    - echo ${CI_RUNNER_DESCRIPTION}
+    - echo "RUNNER_NAME=${CI_RUNNER_DESCRIPTION}" > runner.env
+
+publish-bench:


do you need to use paritytech/ci-linux here? It's better off with a lighter paritytech/tools

It's better off with a lighter paritytech/tools

Agree, fixed

then it maybe makes sense to remove that default image from k8s anchor.

I'd prefer to keep k8s anchor as it is so it is equal through all our .gitlab-ci.yml files in different repos

.scripts/ci/push_bench_results.sh

Co-authored-by: Denis Pisarev <17856421+TriplEight@users.noreply.github.com>

dvdplm · 2021-11-30T15:37:51Z

.gitlab-ci.yml

+  stage:                           lint
+  <<:                              *kubernetes-env
+  script:
+    - rustup component add rustfmt


I'd prefer cargo fmt from stable, but cargo +nightly fmt works too.

dvdplm · 2021-11-30T15:39:07Z

.gitlab-ci.yml

+  stage:                           lint
+  <<:                              *docker-env
+  script:
+    - rustup component add clippy


Same as above, I prefer CI to use stable but yes, I'm ok running nightly clippy too. Curious though, why is clippy not included in the base image?

scripts/ci/pre_cache.sh

dvdplm · 2021-11-30T15:45:18Z

anyone knows why?

@radupopa2010 I think we need to merge master in here.

alvicsam · 2021-11-30T16:06:36Z

anyone knows why?

rebase fixed the pipeline

alvicsam · 2021-11-30T16:17:56Z

@niklasad1

A follow-up question, is it possible to have similar alerts as the GHA action when regressions are detected?

I think it's possible. I see a few options: send an email, send a matrix message or create a GitHub issue. I can create a new issue in our tracker where we can discuss the way how alert is sent and the conditions.

.gitlab-ci.yml

TriplEight · 2021-12-02T13:41:26Z

.gitlab-ci.yml

+  stage:                           lint
+  <<:                              *kubernetes-env
+  script:
+    - rustup component add rustfmt


it's not a big deal, we can add it to the CI image for stable, too.

TriplEight · 2021-12-02T13:43:03Z

.gitlab-ci.yml

+  stage:                           lint
+  <<:                              *docker-env
+  script:
+    - rustup component add clippy


You mean paritytech/base-ci-linux? It was never requested before to run a stable clippy or fmt.

TriplEight · 2021-12-02T13:45:06Z

.gitlab-ci.yml

+    - echo ${CI_RUNNER_DESCRIPTION}
+    - echo "RUNNER_NAME=${CI_RUNNER_DESCRIPTION}" > runner.env
+
+publish-bench:


then it maybe makes sense to remove that default image from k8s anchor.

niklasad1 reviewed Oct 19, 2021

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

niklasad1 reviewed Oct 19, 2021

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

niklasad1 reviewed Oct 19, 2021

View reviewed changes

.gitlab-ci.yml Show resolved Hide resolved

niklasad1 reviewed Oct 19, 2021

View reviewed changes

.gitlab-ci.yml Show resolved Hide resolved

alvicsam changed the title ~~As add gitlabci~~ WIP: Create gitlab pipeline Oct 19, 2021

alvicsam requested review from niklasad1, TriplEight, rcny and sergejparity October 21, 2021 12:14

alvicsam changed the title ~~WIP: Create gitlab pipeline~~ Create gitlab pipeline Oct 21, 2021

rcny approved these changes Oct 21, 2021

View reviewed changes

dvdplm reviewed Oct 22, 2021

View reviewed changes

niklasad1 reviewed Oct 22, 2021

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

niklasad1 reviewed Oct 22, 2021

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

niklasad1 reviewed Oct 22, 2021

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

alvicsam requested a review from niklasad1 October 22, 2021 15:15

niklasad1 reviewed Oct 22, 2021

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

niklasad1 reviewed Oct 22, 2021

View reviewed changes

niklasad1 requested a review from dvdplm October 22, 2021 16:37

niklasad1 mentioned this pull request Nov 5, 2021

ci: run check on each feature individually #552

Merged

niklasad1 closed this in #552 Nov 5, 2021

niklasad1 reopened this Nov 8, 2021

alvicsam added 9 commits November 30, 2021 13:04

empty commit for benchmark test

cf0ae9f

add cirunner label to vm metric

39adb0f

split vm metric to 2 metrics

a6d6258

change runner description to runner tag in ci scripts

5b7f149

add pass runner tags from benchmark to publish job

18bfe81

change runner tag to runner description

864b89b

add debug message

ccd8f7d

empty commit for test

51d4ca9

empty commit for test

7f76577

alvicsam force-pushed the as-add-gitlabci branch from fb17068 to 7f76577 Compare November 30, 2021 12:06

TriplEight suggested changes Nov 30, 2021

View reviewed changes

alvicsam and others added 2 commits November 30, 2021 15:07

Update .scripts/ci/push_bench_results.sh

4e214fb

Co-authored-by: Denis Pisarev <17856421+TriplEight@users.noreply.github.com>

add defaults, remove dups, change ci image for publish-bench

b0163ba

dvdplm reviewed Nov 30, 2021

View reviewed changes

remove pre_cache.sh

4ffeeac

alvicsam requested a review from TriplEight November 30, 2021 16:43

TriplEight suggested changes Dec 2, 2021

View reviewed changes

move interruptible to defaults

9b4b815

alvicsam mentioned this pull request Dec 2, 2021

Add rustfmt,clippy to ci-linux for jsonrpsee paritytech/scripts#362

Merged

maciejhirsz approved these changes Dec 2, 2021

View reviewed changes

add issue to fixme comment

bd12ab4

alvicsam requested a review from TriplEight December 2, 2021 15:25

TriplEight approved these changes Dec 2, 2021

View reviewed changes

alvicsam merged commit 66aa6c4 into master Dec 2, 2021

alvicsam deleted the as-add-gitlabci branch December 2, 2021 15:33

This was referenced Dec 10, 2021

ci: expose benchmark results from internal Gitlab and plot in GH-pages #600

Closed

ci: remove GHA daily benchmark #598

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create gitlab pipeline #534

Create gitlab pipeline #534

alvicsam commented Oct 19, 2021

niklasad1 left a comment

alvicsam commented Oct 19, 2021

niklasad1 commented Oct 19, 2021

dvdplm Oct 22, 2021

alvicsam Oct 22, 2021

dvdplm Oct 22, 2021

TriplEight Nov 30, 2021

dvdplm Nov 30, 2021

TriplEight Dec 2, 2021

alvicsam Dec 2, 2021

dvdplm Oct 22, 2021

TriplEight Nov 30, 2021

dvdplm Nov 30, 2021

TriplEight Dec 2, 2021

niklasad1 left a comment

dvdplm commented Oct 22, 2021

TriplEight commented Nov 4, 2021 •

edited

TriplEight commented Nov 4, 2021

niklasad1 commented Nov 4, 2021

alvicsam commented Nov 8, 2021

TriplEight Nov 30, 2021

TriplEight Nov 30, 2021

TriplEight Nov 30, 2021

alvicsam Nov 30, 2021

TriplEight Dec 2, 2021

alvicsam Dec 2, 2021 •

edited

dvdplm Nov 30, 2021

dvdplm Nov 30, 2021

dvdplm commented Nov 30, 2021

alvicsam commented Nov 30, 2021

alvicsam commented Nov 30, 2021

TriplEight Dec 2, 2021

TriplEight Dec 2, 2021

TriplEight Dec 2, 2021

Create gitlab pipeline #534

Create gitlab pipeline #534

Conversation

alvicsam commented Oct 19, 2021

niklasad1 left a comment

Choose a reason for hiding this comment

alvicsam commented Oct 19, 2021

niklasad1 commented Oct 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niklasad1 left a comment

Choose a reason for hiding this comment

dvdplm commented Oct 22, 2021

TriplEight commented Nov 4, 2021 • edited

TriplEight commented Nov 4, 2021

niklasad1 commented Nov 4, 2021

alvicsam commented Nov 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alvicsam Dec 2, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dvdplm commented Nov 30, 2021

alvicsam commented Nov 30, 2021

alvicsam commented Nov 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TriplEight commented Nov 4, 2021 •

edited

alvicsam Dec 2, 2021 •

edited