Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove GHA daily benchmark #598

Merged
merged 2 commits into from
Dec 10, 2021
Merged

ci: remove GHA daily benchmark #598

merged 2 commits into from
Dec 10, 2021

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Dec 9, 2021

This is removed because a daily Gitlab job was introduced in #534

@niklasad1 niklasad1 requested review from a team as code owners December 9, 2021 15:52

## Users

If your project uses `jsonrpsee` we would like to know. Please open a pull request and add your project to the list below:
- [substrate-subxt](https://github.com/paritytech/substrate-subxt)
- [parity bridges common](https://github.com/paritytech/parity-bridges-common)
- [remote externalities](https://github.com/paritytech/substrate/tree/master/utils/frame/remote-externalities)

## Benchmarks
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not public anymore...

Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll expose new benchmarks in the future if that turns out to be easy enough?

@niklasad1
Copy link
Member Author

niklasad1 commented Dec 10, 2021

I guess we'll expose new benchmarks in the future if that turns out to be easy enough?

Indeed, I'll investigate it when @alvicsam helps us to push the raw result to the gh-pages lemme an issue for that.

EDIT: #600

@dvdplm dvdplm merged commit 9bbfd69 into master Dec 10, 2021
@dvdplm dvdplm deleted the chore-remove-gha-daily-bench branch December 10, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants