Fix deprecated test methods in gssapi tests #2275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the deprecated test methods .assertEquals(), .assertNotEquals() and .assert_() in gssapi tests with their modern equivalents. These methods have been deprecated since Python 3.3, and have finally been removed in Python 3.12. I can't say this makes all the tests pass for me but it at least fixes the obvious errors, so it's an overall improvement.
|
Thanks for this, definitely need to modernize here. Is this the only test file where the deprecated methods are used? It would be good to do a universal cleanup on this all in one pass, I think. |
|
Well, the PR touches 3 files but yes, these are all I've been able to find. Note that I've been grepping for |
|
Lol, whoops - typed that in the singular without thinking. Sounds good, marked as for-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the deprecated test methods .assertEquals(), .assertNotEquals() and .assert_() in gssapi tests with their modern equivalents. These methods have been deprecated since Python 3.3, and have finally been removed in Python 3.12.
I can't say this makes all the tests pass for me but it at least fixes the obvious errors, so it's an overall improvement.