Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assertEqual instead of assertEquals for Python 3.12 compatibility. #2211

Closed
wants to merge 2 commits into from
Closed

Use assertEqual instead of assertEquals for Python 3.12 compatibility. #2211

wants to merge 2 commits into from

Conversation

tirkarthi
Copy link

https://docs.python.org/3.12/whatsnew/3.12.html#removed . This method was removed in Python 3.12

@bskinn
Copy link
Contributor

bskinn commented Mar 17, 2023

Thanks for the PR! I think I remember seeing this.

Looks like you've done a pretty thorough job, but to be sure: Have you checked the entire test suite for this deprecated usage?

Is the new method available in Python 3.6+? (There are jobs in the CI that test on 3.6, so I'm guessing this is all good, but want to specifically ask.)

This is worth a CHANGELOG entry -- please add one, if you would.

@bskinn
Copy link
Contributor

bskinn commented Aug 16, 2023

It looks like @mgorny found two more instances that needed replacement in #2275. Closing this PR in favor of that one. Thank you for this PR, though, @tirkarthi!

@bskinn bskinn closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants