Pin pytest 7.0.1 #14997
Merged
Pin pytest 7.0.1 #14997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has a conftest.py-related bug that has hit at least one user. [ci skip-rust] [ci skip-build-wheels]
benjyw
commented
Apr 4, 2022
| @@ -314,6 +314,7 @@ class PythonSetup(Subsystem): | |||
| "when building wheels. Otherwise, the default of macosx_11_0 will be used. " | |||
| "This may be required for pip to be able to install the resulting distribution " | |||
| "on Big Sur.", | |||
| advanced=True, | |||
There was a problem hiding this comment.
Unrelated but not worth a PR of its own.
|
Will wait for confirmation that 7.1.1 fixes the issue before merging this. If it doesn't, will change to pin to 7.0.1. |
|
Addresses #14990 |
Eric-Arellano
approved these changes
Apr 4, 2022
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
I did regenerate the lockfile, are you not seeing it? Or am I missing something? |
|
But I'll have to regenerate at least the user lockfile anyway due to this merge collision. |
|
You re-generated our own internal lock file, but not the default one that we distribute to users https://github.com/pantsbuild/pants/blob/main/src/python/pants/backend/python/subsystems/pytest.lock |
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Apr 5, 2022
The latest releases (7.1.0, and 7.1.1 so far) have a conftest.py-related bug that has hit at least one user. See pantsbuild#14990 [ci skip-rust] [ci skip-build-wheels]
benjyw
added a commit
that referenced
this pull request
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest releases (7.1.0, and 7.1.1 so far) have a conftest.py-related bug that has hit at least one user.
See #14990
[ci skip-rust]
[ci skip-build-wheels]