Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest 7.1.0 can cause conftest.py loading issues #14990

Closed
stuhood opened this issue Apr 4, 2022 · 2 comments
Closed

pytest 7.1.0 can cause conftest.py loading issues #14990

stuhood opened this issue Apr 4, 2022 · 2 comments
Assignees
@benjyw
Milestone
2.11.x

Comments

@stuhood
Copy link
Sponsor Member

stuhood commented Apr 4, 2022

A user upgrading to 2.11.x experienced a pytest issue that causes conftest.py to be loaded twice.

We should consider downgrading to 7.0.1 by default in 2.11.x, and waiting for a fix.
@stuhood stuhood added this to the 2.11.x milestone Apr 4, 2022
@benjyw benjyw self-assigned this Apr 4, 2022
@benjyw benjyw mentioned this issue Apr 4, 2022
Merged
@benjyw
Copy link
Sponsor Contributor

benjyw commented Apr 5, 2022

Apparently this issue persists in pytest 7.1.1, even though that version claims to fix pytest-dev/pytest#9493, so it may be another issue.

benjyw added a commit that referenced this issue Apr 5, 2022
@benjyw
Pin pytest 7.0.1 (#14997)
0716c80 
The latest releases (7.1.0, and 7.1.1 so far) have a conftest.py-related bug that has hit at least one user.

See #14990

[ci skip-rust]

[ci skip-build-wheels]
benjyw added a commit to benjyw/pants that referenced this issue Apr 5, 2022
@benjyw
Pin pytest 7.0.1 (pantsbuild#14997)
fb1c897 
The latest releases (7.1.0, and 7.1.1 so far) have a conftest.py-related bug that has hit at least one user.

See pantsbuild#14990

[ci skip-rust]

[ci skip-build-wheels]
@benjyw
Copy link
Sponsor Contributor

benjyw commented Apr 5, 2022

Addressed in #14997

@benjyw benjyw closed this as completed Apr 5, 2022
@benjyw benjyw mentioned this issue Apr 5, 2022
Merged
benjyw added a commit that referenced this issue Apr 6, 2022
@benjyw
Pin pytest 7.0.1 (cherrypick of #14997) (#15013)
4802dc3 
The latest releases (7.1.0, and 7.1.1 so far) have a conftest.py-related bug that has hit at least one user.

See #14990

[ci skip-rust]

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjyw benjyw

Labels
None yet
Projects
None yet
Milestone
2.11.x
Development

No branches or pull requests
2 participants
@stuhood @benjyw