DEPR: numeric_only default in resampler ops #47177
Conversation
rhshadrach
added
Resample
pandas/core/resample.py
Outdated
| @@ -937,25 +936,27 @@ def asfreq(self, fill_value=None): | |||
| """ | |||
| return self._upsample("asfreq", fill_value=fill_value) | |||
|
|
|||
| def std(self, ddof=1, *args, **kwargs): | |||
| def std(self, ddof=1, numeric_only: bool = False): | |||
There was a problem hiding this comment.
@mroeschke - I believe you've done a bunch of work in resample/window; do you know why args/kwargs exist on these ops? They seem to be on all these methods only to check that the user didn't pass anything to them. I'm going to revert these removals here, but was thinking about doing a cleanup of these in a separate PR if they aren't useful. Checking the history here, there is some indication of compatibility with numpy in #12810, but I don't understand it.
There was a problem hiding this comment.
I think the numpy compatibility was such that one could call e.g. np.mean(df.groupby/resample/rolling) and get the equivalent call to df.groupby/resample/rolling.mean(). Not sure why that compatibility was desired or if it was widely tested (guessing not if tests are passing).
FWIW I think I broke this compatibility too when I added engine keywords to the window and groupby reduction ops, so I'd be +1 to clean these *args, **kwargs
|
thanks @rhshadrach |
Part of #46560
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.