Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: enforce deprecation of old set_axis signature #30089

Merged
merged 3 commits into from
Dec 6, 2019
Merged

DEPR: enforce deprecation of old set_axis signature #30089

merged 3 commits into from
Dec 6, 2019

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jreback jreback added the Deprecate Functionality to remove in pandas label Dec 5, 2019
@jreback jreback added this to the 1.0 milestone Dec 5, 2019
@jreback
Copy link
Contributor

jreback commented Dec 5, 2019

lgtm ping on green.

@jbrockmendel
Copy link
Member Author

We're running out of things to remove in #6581! One thing there that could use a look from someone more experienced than me is the how/fill_method/resample one (now top of this list). My last attempt to enforce it didn't go well.

@jreback
Copy link
Contributor

jreback commented Dec 5, 2019

We're running out of things to remove in #6581! One thing there that could use a look from someone more experienced than me is the how/fill_method/resample one (now top of this list). My last attempt to enforce it didn't go well.

lol, yeah I added that too.

did you have a branch for this?

@jbrockmendel
Copy link
Member Author

did you have a branch for this?

not one that i pushed, will have to see if i still have it locally

@jbrockmendel
Copy link
Member Author

de facto green. im going to try to see if the same codecs.open thing can fix the CI failure were seeing here

@jbrockmendel
Copy link
Member Author

booyah! tentatively figured out why we're leaking files that is failing the py36 build occasionally

@jreback jreback merged commit f437a04 into pandas-dev:master Dec 6, 2019
@jreback
Copy link
Contributor

jreback commented Dec 6, 2019

thanks

@jbrockmendel jbrockmendel deleted the depr-set_axis branch December 6, 2019 15:24
@jreback jreback mentioned this pull request Dec 6, 2019
Closed
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
DEPR: enforce deprecation of old set_axis signature (pandas-dev#30089)
77698c8
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
DEPR: enforce deprecation of old set_axis signature (pandas-dev#30089)
d516ea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbrockmendel @jreback