Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Open shares without having to accept it #9784

Closed
tbsbdr opened this issue Oct 9, 2023 · 6 comments · Fixed by #10887
Closed

[web] Open shares without having to accept it #9784

tbsbdr opened this issue Oct 9, 2023 · 6 comments · Fixed by #10887
Assignees
@JammingBen
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Oct 9, 2023 •
edited

Description

User Stories

  • As a user I don't want to accept shares so that I can just klick on a share to access it.

Value

Acceptance Criteria

  • klick on a share shows the resource
  • no "accept" aka "sync" needed

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Oct 9, 2023 •
edited by JammingBen

depend on Sharing NG and #9709

Open question:

  • How to retrieve unaccepted/unsynced shares: via mount points (they are currently missing) or does Web need to fetch mount points and OCS API @micbar @butonic

To-Dos for Web: (hopefully) only adjust mount point fetching if we go via the first solution

@JammingBen JammingBen changed the title [web] Open links without having to accept it [web] Open shares without having to accept it Oct 9, 2023
@JammingBen JammingBen added the Type:Story User Story label Oct 9, 2023
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Oct 25, 2023

depends on sharing NG

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Apr 24, 2024

@JammingBen could you list what would be needed to move this issue forward?

@tbsbdr tbsbdr added the Priority:p2-high Escalation, on top of current planning, release blocker label Apr 24, 2024
@JammingBen
Copy link
Collaborator

@JammingBen could you list what would be needed to move this issue forward?

@dschmidt Do you know from the top of your head? 🤔 I need to dig into this topic again...

@JammingBen
Copy link
Collaborator

As discussed with @dschmidt , we need to do some research here as this topic is super complex and none of us remembers the exact things that are needed here. I hope to come up with something early next week so we might be able to tackle this within the next sprint.

@JammingBen
Copy link
Collaborator

Okay so I digged into it, looks like we have all the necessary information from the server now. So all that's necessary is to get started in Web.

@JammingBen JammingBen self-assigned this May 7, 2024
This was referenced May 7, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JammingBen JammingBen

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Story User Story
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make unsynced shares accessible owncloud/web
2 participants
@tbsbdr @JammingBen