feat: make unsynced shares accessible #10887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Todo: handle legacy urls |
Discussed with @tbsbdr , it's okay for the URLs to break because of the Edit: We decided to built a fallback anyway since it was easy. |
JammingBen
force-pushed
the
access-unsynced-shares
branch
from
a884e47
to
ef25b0d
Compare
Makes unsynced shares accessible. The way to make this work is by using the remote item id instead of the share jail id for opening/resolving into incoming shares. In the future we should rethink the `shareId` property since the name is not really fitting anymore. `remoteItemId` would be more fitting.
JammingBen
force-pushed
the
access-unsynced-shares
branch
from
ef25b0d
to
72f1be7
Compare
Renames `shareId` to `remoteItemId` and `shareRoot` to `remoteItemPath` on resources to match with the Graph terminology. Also removes the `remoteItemId` on space resources because it only matters for share spaces, in which case this is simply the space id. That means instead of blindly going for `space.remoteItemId`, it now checks if the space is actually a share space and then uses its id.
JammingBen
force-pushed
the
access-unsynced-shares
branch
from
72f1be7
to
1ea70fc
Compare
JammingBen
force-pushed
the
access-unsynced-shares
branch
from
1ea70fc
to
3fc1480
Compare
|
AlexAndBear
approved these changes
May 17, 2024
Agreed, I created #10931 to keep track. |
|
Congrats to us! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes unsynced shares accessible. The way to make this work is by using the remote item id instead of the share jail id for opening/resolving into incoming shares.
Notable changes in the course of this:
shareIdtoremoteItemIdandshareRoottoremoteItemPathon resources to match with the Graph terminology.remoteItemIdon space resources because it only matters for share spaces, in which case this is simply the space id. That means instead of blindly going forspace.remoteItemId, it now checks if the space is actually a share space and then uses its id.Related Issue
Types of changes