Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run acceptance tests with PHP 7.3 #36148

Closed
wants to merge 2 commits into from

Conversation

phil-davis
Copy link
Contributor

Description

Run acceptance tests wwith PHP 7.3 to demonstrate that all is still well.

Related Issue

#36142

How Has This Been Tested?

CI

This is a test demonstration - not for merging.

@phil-davis phil-davis self-assigned this Sep 4, 2019
@davitol davitol mentioned this pull request Sep 4, 2019
13 tasks
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #36148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36148   +/-   ##
=======================================
  Coverage   54.01%   54.01%           
=======================================
  Files          63       63           
  Lines        7404     7404           
  Branches     1309     1309           
=======================================
  Hits         3999     3999           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ececf51...170db1b. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #36148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36148   +/-   ##
=======================================
  Coverage   54.01%   54.01%           
=======================================
  Files          63       63           
  Lines        7404     7404           
  Branches     1309     1309           
=======================================
  Hits         3999     3999           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ececf51...6a46b3b. Read the comment docs.

@phil-davis
Copy link
Contributor Author

works - great stuff.

@phil-davis phil-davis closed this Sep 4, 2019
@phil-davis phil-davis deleted the acceptance-tests-with-php7.3 branch June 18, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant