10.3 - Changelog test Results

[davitol]

Added

• Support for php 7.3 [stable10] support php7.3 #34559 [stable10] Fix method signature of ExceptionLoggerPlugin::logException to allow … #35775 [stable10] Adjust PHP max version comments #35752 @phil-davis PR Run acceptance tests with PHP 7.3 #36148 demonstrates acceptance tests with PHP 7.3
• Support for redirecting private links to ownCloud phoenix frontend In case phoenix is configured to be used with this instance - private… #35819 @individual-it
• encryption:fixencryptedversion command to address issues related to encrypted versions Add encryption version fix command encryption#115 ❌ functionality is OK, but output is not good command to fix encrypted versions shows content of all files encryption#146 @individual-it
• Tech preview DAV endpoint for public shares Feature/public links #35932 Handle error scenario in File::putContent #36057 Don't list files on file drop folders + rename existing files when up… #36021 Handle quota scenario on public-files #36059 Handle no longer existing resource of a link share #36066 PublicFiles: Quote ETag in headers as well #36080 Add proper ACLs on PublicSharedRootNode #36061 Block listing children of upload-only folder on GET request #36119 fix file creation with content in public webdav api #36049 Fixes #36067 - start rename index with 2 #36068 @phil-davis tested by CI, endpoints are disabled by default by Disable trashbin and public webdav API by default #36124
• Tech preview DAV endpoint for trashbin [stable10] Webdav TrashBin API #35716 Handle exception properly when deleting trash items #35879 ETag has to be surrounded by double quotes #36053 Fix single trashbin item deletion via DAV endpoint #36073 @phil-davis tested by CI, endpoints are disabled by default by Disable trashbin and public webdav API by default #36124
• OCS Roles API and ability to set permissions via share attributes - Roles API + allow setting permissions via share attribues #36024 Fix bug with attribute disabled being saved as null #36086 @individual-it (not tested every possible security issue, need automated tests)
• OCS API for public link share email notification - add ocs api for public link share email notification #36063 ❌ api for public link share email notification does not obey Allow users to send mail notification for shared files #36156 The new public link email API requires CSRF token #36157 Fixed in RC1
• JS API v2 for share attributes - Share item model attributes javascript api v2 #35836 @phil-davis Initial drone starlark richdocuments#276 demonstrates this passing against 10.3.0alpha2
• Url /cron in addition to /cron.php to execute cronjobs via webcron [stable10] Have a real controller handling cron requests #34932 @individual-it
• system:cron occ command for executing background tasks via system cron [stable10] Have a real controller handling cron requests #34932 @individual-it
• previews_path config option to configure thumbnail storage path [stable10] Allow configuring thumbnails path #35131 @individual-it
• Show activity when share receiver unshares a received share [stable10] add activity for self unshare action #35193 @HariBhandari07
• Document phoenix.baseUrl in config.sample.php - Document phoenix.baseUrl in config.sample.php #36007 @individual-it typos fixed in fixed typos in 'phoenix.baseUrl' documentation #36152

[davitol]

Changed

• Allow two-factor providers to display custom challenge message Two factor auth message #34848 @davitol
• Handling of unauthenticated ajax requests to prevent browser issues Don't send WWW-Authenticate headers with schema Basic for ajax requests #36003
• Improved share permission handling Refactor share permissions handling #35884 🤖 a lot of tests were added
• Refined user administration setting button Added description for the user settings section #35877 @HariBhandari07
• Improved mobile device experience Minor mobile view adjustments for portrait mode #35919 Limit the width of the set password button #35813 [stable10] Center the logo and login fields for setup page #35347 @HariBhandari07
• Reference the new iOS app in the list of available applications Added the new iOS app #35918 @davitol Test steps: Click on iOS app banner and check you are redirected to https://apps.apple.com/app/id1359583808
• Improved sharing autocomplete dropdown layout [stable10] use a multi line approach to display share autocomplete #35397 @HariBhandari07
• Improved theming capabilities by allowing html for Name and LogoClaim [Stable10] allow html in claim and use htmlname in layout #35273 @individual-it need to be mentioned in the release noted that the logo and claim will change
• Improved private link UX for large resolutions Limiting the maximum width of .fileName in #app-sidebar #34998 @davitol Test steps: Limiting the maximum width of .fileName in #app-sidebar #34998 (comment)
• Improved wording for several user/administrator encryption related interactions Add re-login information after successful action encryption#21 Fix minor wording corrections in command encryption#117 @individual-it
• Handling of composer autoloader for apps/files_external [stable10] Remove $CLASSPATH and move autoloader to namespace #35755 tested by CI and smoke test of SMB external storage @individual-it
• Renamed share icon to be adblock friendly [stable10] Rename share icon to be adblock friendly #35199 @HariBhandari07
• Bump symfony/polyfill components from v1.11.0 to v1.12.0 Updating symfony/polyfill-* (v1.11.0 => v1.12.0) #35989 - tested by CI and smoke test
• Bump @bower_components/handlebars from v4.1.1 to v4.1.2 [stable10] Bump @bower_components/handlebars from v4.1.1 to v4.1.2 in /build #35025 tested by CI and smoke test
• Bump @bower_components/jsTimezoneDetect from 1.0.5 to v1.0.6 [stable10] Bump @bower_components/jsTimezoneDetect from 1.0.5 to v1.0.6 in /build #33776 @individual-it smoke tests with calendar app & upgrade from 10.2.1
• Bump doctrine/lexer from v1.0.1 to 1.0.2 [stable10] dependency bumps to 20190627 #35625 - tested by CI and smoke test
• Bump egulias/email-validator from 2.1.7 to 2.1.11 [stable10] Updating egulias/email-validator (2.1.7 => 2.1.8) #35341 [stable10] dependency bumps to 20190627 #35625 [stable10] composer updates 20190728 #35934 Updating egulias/email-validator (2.1.10 => 2.1.11) #36026 Updating egulias/email-validator (2.1.10 => 2.1.11) #36026 - tested by CI and smoke test
• Bump icewind/smb from 3.1.1 to 3.1.2 Bump icewind/smb from 3.1.1 to 3.1.2 in /apps/files_external/3rdparty #36017 tested by CI and smoke test
• Bump icewind/smb from 3.1.1 to 3.1.2 in /apps/files_external/3rdparty - Bump icewind/smb from 3.1.1 to 3.1.2 in /apps/files_external/3rdparty #36017 tested by CI and smoke test
• Bump league/flysystem from 1.0.51 to 1.0.55 [stable10] Bump league/flysystem from 1.0.51 to 1.0.52 #35275 [stable10] Bump league/flysystem from 1.0.52 to 1.0.53 #35644 Bump league/flysystem from 1.0.53 to 1.0.55 #36099 tested by CI and smoke test
• Bump nikic/php-parser from 4.2.1 to 4.2.3 [stable10] Bump nikic/php-parser from 4.2.1 to 4.2.2 #35337 Bump nikic/php-parser from 4.2.2 to 4.2.3 #36015 Bump nikic/php-parser from 4.2.2 to 4.2.3 #36015 - tested by CI and smoke test
• Bump phan to 1.3.5 and enable on PHP 7.2 7.3 - Bump phan to 1.3.5 and enable on PHP 7.2 7.3 #35818 - tested by CI and smoke test
• Bump phpseclib/phpseclib from 2.0.15 to 2.0.21 [stable10] Bump phpseclib/phpseclib from 2.0.15 to 2.0.17 #35336 [stable10] Bump phpseclib/phpseclib from 2.0.17 to 2.0.18 #35565 [stable10] Bump phpseclib/phpseclib from 2.0.18 to 2.0.20 #35643 [stable10] Bump phpseclib/phpseclib from 2.0.20 to 2.0.21 #35827 tested by CI and smoke test
• Bump league/flysystem from 1.0.51 to 1.0.53 [stable10] Bump league/flysystem from 1.0.51 to 1.0.52 #35275 [stable10] Bump league/flysystem from 1.0.52 to 1.0.53 #35644 tested by CI and smoke test
• Bump sabre/dav from 3.2 to 4.0.1 [stable10] support php7.3 #34559 Bump sabre/dav from 4.0.0 to 4.0.1 #36094 tested by CI and smoke test
• Bump sabre/xml 2.1.2 from to 2.1.3 Updating sabre/xml (2.1.2 => 2.1.3) #36036 Updating sabre/xml (2.1.2 => 2.1.3) #36036 tested by CI and smoke test
• Bump swiftmailer/swiftmailer from 6.2.0 to 6.2.1 [stable10] Bump swiftmailer/swiftmailer from 6.2.0 to 6.2.1 #35075 tested by CI and smoke test
• Bump symfony from v3.4.26 to v3.4.31 [stable10] Bump symfony v3.4.26 => v3.4.27 #35146 [stable10] Bump symfony v3.4.27 => v3.4.28 #35348 [stable10] dependency bumps to 20190627 #35625 [stable10] composer updates 20190728 #35934 Bump symfony/console from 3.4.30 to 3.4.31 #36098 Bump symfony/event-dispatcher from 3.4.30 to 3.4.31 #36097 Updating symfony/polyfill-* (v1.11.0 => v1.12.0) #35989 Bump symfony/process from 3.4.30 to 3.4.31 #36095 Bump symfony/routing from 3.4.30 to 3.4.31 #36096 Bump symfony/translation from 3.4.30 to 3.4.31 #36093 - tested by CI and smoke test
• Bump theseer/tokenizer from 1.1.2 to 1.1.3 [stable10] dependency bumps to 20190627 #35625 - tested by CI and smoke test
• Updating webmozart/assert (1.4.0 => 1.5.0) - Updating webmozart/assert (1.4.0 => 1.5.0) #36103 - tested by CI and smoke test
• Updating zendframework/zend-filter (2.9.1 => 2.9.2) - Updating zendframework/zend-filter (2.9.1 => 2.9.2) #36102 - tested by CI and smoke test
• Updating zendframework/zend-inputfilter (2.10.0 => 2.10.1) - Updating zendframework/zend-inputfilter (2.10.0 => 2.10.1) #36112 - tested by CI and smoke test
• Update the minimum required Node engine version to 8.15.0 - Update the minimum required Node engine version to 8.15.0 #36033 - tested by CI and smoke test

[davitol]

Removed

• Deprecated update script from files app [stable10] Remove not longer valid update script - pre-8.1 upgrade #35781 @HariBhandari07
• Dropped APC and XCache support [stable10] Kill APC and XCache - fixes #28597 #35782 @phil-davis CI and general manual tests confirm the system is working without this code
• Old table repair step will drop deprecated contacts_cards_properties table #35721 @davitol Test steps: Install oC 9.0 and contacts app. Check the table exists. Upgrade to oC 10.3. Check the table no longer exists
• Removed support for swift as primary / external storage Remove swift primary and secondary storage support #35951 @davitol Automated tests and checked the Swift option is no longer shown
• Moved S3 external integration into separate app (files_external_s3) #349862 ❌ @davitol (Issues: S3 files external mountpoints are no longer available when upgrading from oC 10.2.1 to 10.3 alpha2 files_external_s3#235 , Cannot configure an external mountpoint Amazon S3 using files_external_S3 1.0.0RC1 and oC 10.3 alpha files_external_s3#230)
• Moved ownCloud default encryption app into separate repository Remove encryption app #35949 @davitol Test results here: Tracking testing results for encryption encryption#142

[davitol]

Fixed

• Use bit operators when checking share file permission - use bit operators when checking file permission, resolves #36025 #36111 @HariBhandari07
• Only share owner should be able to update or delete share - only share owner and sharer update or delete share #36120 @HariBhandari07
• Fix various issues with session handling in relation to redis - Session fixes #35888 ❌ webinstaller does not work with 10.3.0alpha2 #36149
• Fix issue where IE did not redirect to login page when user is not logged in - IE doesn't redirect to login page when user is not logged in #36079 @davitol Test steps: With IE as browser, open register link from mail and check it works
• Check that all user mount points has unique names - Mountpoint collision #36029 @HariBhandari07
• Fix loading of app.php when using a separate apps folder - Do not rely on include path #36054 @davitol Test Steps: install OC 10.3 with the default app directories apps is non-writable, apps-external is writable.
  Copy any app from apps into apps-external, increase version in apps-external/appname/appinfo/app.php and check that the app:list shows the highest version
• Respect default app config within the TwoFactorChallengeController - Respect default app config within the TwoFactorChallendeController #36031 @davitol Test steps: Set in config.php 'defaultapp' => 'market'. Log in with 2FA and check market is shown at login,
• Don't send WWW-Authenticate headers with schema Basic for ajax requests - Don't send WWW-Authenticate headers with schema Basic for ajax requests #36003 @davitol Test stepes: test 'old' web frontend with different browsers
• Fix issue when share folder and shares go missing when storage becomes unavailable - Restrict deletion of share_folder by user #35998 @HariBhandari07
• Handling of OCM sharing when receiving server did not include a protocol (i.e. https) [stable10] [OCM] Set unknown remote protocol for remote mounts to https #35711
• Performance improvements when loading groups of users Bugfix/not load groups if not necessary #35822 🤖
• Relative path handling for files:checksums:verify occ command [stable10] Backport of Fix path option in the verify checksum cmd #35694 @davitol Test steps: Fix path option for the verify checksum command #35483 (comment)
• Failed rename operation leading to unavailable external storage Return false if the rename fails except for connect exceptions #35598 @HariBhandari07
• Comment creation event missing ID field [stable10] Backport of Comment create event should have comment id #35799 @davitol *Test steps: [stable10] Backport of Comment create event should have comment id #35799 (comment)
• Improved handling of share expire input fields to avoid user error [stable10] Fix expire days value #35779 @HariBhandari07
• Refactored user creation in order to allow same flow for occ and api Move user creation to a separate service #35972 @HariBhandari07
• Maintain dav properties when files are moved to trashbin Keep DAV properties when file goes to trashbin #35954 @davitol Test steps here: Keep DAV properties when file goes to trashbin #35954 (comment)
• Usage of domain when authenticate with SMB/WND shares Fix SMB domain usage #35892
• Triggering dav events on the public webdav endpoint Backport of Trigger dav events for the public.php/webdav endpoint #35820 🤖 https://github.com/owncloud/admin_audit/pull/212
• Prevent deletion of configured share_folder Restrict deletion of share_folder by user #35998 @HariBhandari07
• Issues with improper displayed languages read the correct translations #35973 @HariBhandari07
• Respect user.min_search_length with federated sharing obey user min search length configuration on remote shares #35977 @HariBhandari07
• Avoid password manager autocomplete on user administration Tell the browser not to autofill those password fields #35931 @HariBhandari07
• Changing config settings produced duplicate emitted events [stable10] Backport of Remove duplicate events emitted in Config #35875 @davitol Tests steps: audit logs are no longer duplicated with this change.
• Properly return StorageNotAvailable on network failures with external storages [stable10] Convert StorageNotAvailable to Sabre one if can't get the child #35707 @individual-it
• Improved error message when trying to share with a non-existing federated user [Stable10] Fed Sharing: Preserve error message coming from the share-to host. #35542 @HariBhandari07
• Allow selection of UI errors during web-installation [stable10] Allow selecting installation errors #35681 @HariBhandari07
• Added missing events for webdav copy operations on new endpoint [Stable10] Emit copy and post copy hooks for the new dav endpoint #35604 @individual-it
• Double-appearing address book entries when shared with groups [Stable10] Filter double appearing addressbooks #35603 @davitol Test steps: [Stable10] Filter double appearing addressbooks #35603 (comment)
• Issues with federation when proxy requires credentials [stable10] Fix webdavclient proxy credentials #35868 @davitol Test steps: Federation behind a Proxy is now possible
• Respect share_folder with federated shares [Stable10] received shares must go into share_folder when configured #35396 @HariBhandari07
• ❌ Issues with sqlite to mysql migration with db:convert-type [Stable10] Replay migrations on the created schema before copying data #35390 @davitol Cannot make it work.Test steps: [Stable10] Replay migrations on the created schema before copying data #35390 (comment) Fails occ db:convert-type doesn't work with migration #27075 (comment)
• Upload issues with mismatching checksums Remove the uploaded file if there is a checksum error #35294 @davitol Tests steps: https://github.com/owncloud/enterprise/issues/3101#issue-400884916 NOTE: I WAS NOT ABLE TO REPRODUCE THE ISSUE IN PREVIOUS VERSIONS
• Improved memory handling for trashbin expiry background job [stable10] fix memory problems #35708
• Proper handling of objecstorage S3 issues on object upload for files_primary_s3 core [stable10] Backport of Add new exceptions for objectstore #35389 Throw exception when the file is not written to the storage files_primary_s3#212 @davitol Test steps: Throw exception when the file is not written to the storage files_primary_s3#212 (comment)
• Improved mobile view for file drop links ❌ Fix for File Drop view #34803 @HariBhandari07
• Ignore case of userid in occ files:scan command detect correct uid when even wrong casing in given uid for files:scan #35324 @HariBhandari07
• Properly handle errors from remote server when declining a non-existing federated share [Stable10] Catch internal server error from remote on decline #35321 @davitol ❌ Test steps: Decline a non-existing share and check it returns 410. Anyway the PR prevents this exception from appearing in the log file [Stable10] Catch internal server error from remote on decline #35321 (comment)
• Direct access to sharing tab for long file listings [stable10] Backport of Accessing sharetab directly for a long list of files #35306 @HariBhandari07
• Improved OCM compliance on providerId and remoteId fields [stable10] OCM Convert providerId/remoteId into string #35122 @HariBhandari07
• Issue with adding multiple Google Drive external storages [stable10] fix multi gdrive external storage bug #34987 @davitol Tests steps: Add multiple gdrive external storage. It works
• Issues with recreating masterkeys when HSM is used Recreate masterkey should work with HSM encryption encryption#125 @davitol Test Steps: Configure hsmdaemon and check encrytion works. ./occ config:app:set encryption hsm.jwt.secret --value 'secret' ./occ config:app:set encryption hsm.url --value 'http://localhost:8513'`
  `./occ encryption:enable; ./occ encryption:select-encryption-type masterkey -y

[micbar]

Fixed in RC1

Changelog testing on RC1

• Bump sabre uri - #36189 @skshetry
• Make sure to parse only if attributes are json string in reshare #3621
• shareowner can edit re-share permissions without any restriction - #36193 🤖 and @skshetry
• Improve logging when a remote host went down suddenly - #36180 @phil-davis good - see test process Improve logging when a remote host went down suddenly #36180 (comment)
• Updating sabre/http (5.0.0 => 5.0.2) - #36192
• Add getReshareAttributes method to shareitemmodel with fix for parsing - #36186 🤖
• Remove hardcoded protocol. - #36127 @dpakach Changes are in release tarball
• obey to config in share mail notifications APIs - #36161 @dpakach sending mail via public mail api is disabled when config says so.
• Fix invalid foreach in SharingBlacklist.php - [Fix invalid foreach in SharingBlacklist.php #36038] (Fix invalid foreach in SharingBlacklist.php #36038) @dpakach covered by unit tests, Invalid argument supplied for foreach SharingBlacklist.php #36037 is fixed and code is included
• Improve share_folder checks in rmdir - #36170 @dpakach , Deletion of shared folder works as expected
• Add new migrations to dav app - #36084 @skshetry
• Disable trashbin and public webdav API by default - #36124 @phil-davis covered by CI, code is in tarball
• Dont check the CSRF token on public link email API - #36158 @skshetry
• fixed typos in 'phoenix.baseUrl' documentation - #36152 @phil-davis typo fixes are in RC1 tarball
• we can't invalidate the token if there isn't a user session active - #36153 @dpakach web installer works, Code is in release tarball

[micbar]

@HanaGemela @jesmrec @davitol
I posted the fixes for 10.3.0RC1
We can do the changelog testing of RC1 as soon as we are through with alpha2

[micbar]

Client Related

• shareowner can edit re-share permissions without any restriction - #36193
• Fix invalid foreach in SharingBlacklist.php - #36038
• Improve share_folder checks in rmdir - #36170

[jesmrec]

Mobile clients tests

---

shareowner can edit re-share permissions without any restriction - #36193

Tested with 10.2.1, problem is not reproducible. With 10.3RC1, owner of an item can edit permissions of the recipient groups, even if the group is recipient of a re-share.

Steps defined in #36107 (comment) were performed.

---

Fix invalid foreach in SharingBlacklist.php

These values were tested as blacklisted groups:

0
1
1.23
1.23e-4
1.098.345
1.4567e-1.23

neither of them were listed as blacklisted, and correctly listed when they weren't blacklisted.

---

Improve share_folder checks in rmdir - #36170

By adding 'share_folder' => '/Shared Folder' to config.php

and following steps: #36170 (comment)

both Android and iOS do not allow to remove the Shared Folder folder in the clients side. Shared folder stays in both sides (client and server).

---

Android:
App version: 2.13 (stable - 87ce8f0)
Device: Nexus 6P, Android 7.1

iOS:
App version: 1.1 (stable - 1e1f5da)
Device: iPhoneX, iOS13.1

Server: 10.3.0 RC1 (testing)

Please, let me know if you miss something.

[HanaGemela]

I've tested the below items on the desktop sync client. All passed. I've added a comment with more details into each issue.

• shareowner can edit re-share permissions without any restriction - shareowner can now edit re-share permissions without any restriction #36193
• Fix invalid foreach in SharingBlacklist.php - Fix invalid foreach in SharingBlacklist.php #36038
• Improve share_folder checks in rmdir - Improve share_folder checks in rmdir #36170

Newly found issues:
share_folder can be shared #36241
Deleted folder is not restored when deletion is not allowed https://github.com/owncloud/client/issues/7496

[micbar]

Release Done.