Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6518 Spam check runs on abuse reports if the email you enter has different capitalization than the email on your account #4755

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

forceofcalm
Copy link
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6518

Purpose

Previously, the spam checker was flagging the report as spam if the casing of the emails for the account and submission did not match. We fixed this by downcasing both values before comparing.

Testing Instructions

  1. Log in
  2. Follow “Policy Questions & Abuse Reports” in the site footer
  3. Change the “Your name (optional)” field to say “akismet-guaranteed-spam,” which will guarantee your report is flagged as spam if the spam checker runs on it
  4. Change the capitalization of the email in the “Your email (required)” field
  5. Fill in rest of form
  6. Submit

Form should submit successfully.

Credit

calm (they/them)

Copy link
Member

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good! But we could use a new example in the abuse report spec to cover this. We currently only have a test that covers emails that are an exact match.

Also, just a reminder to make sure you transition the Jira issue to In Review when you open a pull request. (If you set the issue to In Progress when you start work, the change should happen automatically.) If Jira won't let you do that, please let me know and I'll see if something's wrong with your account permissions.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants