AO3-6622 Decrease margins on definition lists in FAQs #4756
Conversation
| @@ -1,10 +1,11 @@ | |||
| /* ==USERSTUFF: displaying content inputted by a user into a textarea.*/ | |||
|
|
|||
| .userstuff { | |||
| word-wrap: break-word; | |||
| word-wrap: break-word; | |||
There was a problem hiding this comment.
Could you put the spacing back here? Our house style (developed many, many years ago) is to list CSS3 properties last and indent them four spaces.
There was a problem hiding this comment.
Ah, yeah. That's my linter. Let me turn that off for this.
There was a problem hiding this comment.
It looks like this line got fixed! However, all of the other properties are now indented 2 spaces instead of 4. Can you please restore the original indenting across the file?
There was a problem hiding this comment.
All lines should have been fixed with that commit. I just checked again on the diff and it all looks good?
This is a screenshot from my IDE this morning.
Not sure if GH is just being slow to catch up, or what.
There was a problem hiding this comment.
The screenshot matches what GitHub is showing, but the properties should be indented just two spaces, putting them where the second vertical line is. Basically, the lines were correctly indented in the original version of the file and should be unchanged in this PR.
There was a problem hiding this comment.
Wait, so then I'm confused about the original comment, asking to indent them all 4 spaces?
Or does that mean just for CSS3 properties (indent 4), and previous versions are all indented 2?
There was a problem hiding this comment.
Right, just the CSS3 properties get indented 4 spaces (and go last), and the rest get indented 2. Sorry for the confusion!
There was a problem hiding this comment.
Thanks for this! Docs is really going to appreciate it. (Also, apologies for the premature single comment. I was distracted and hit the wrong button.)
If you want to add FAQ data to your dev environment, you can create an admin account with the superadmin, translation, or docs role to access the interface for creating FAQs.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
| width: auto; | ||
| opacity: 1; |
There was a problem hiding this comment.
| opacity: 1; | |
| opacity: 1; |
(If you compare it to word-wrap on line 4, you can see opacity is currently indented a total of 6 spaces instead of the desired 4.)
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
| it "is valid even if the email casing is different" do | ||
| legit_user.email = legit_user.email.upcase | ||
| User.current_user = legit_user | ||
| expect(safe_report.save).to be_truthy | ||
| end | ||
|
|
There was a problem hiding this comment.
This looks like it ended up on the wrong branch, did you mean to to add this to #4755? (If yes, it worries me a bit that the test didn't fail on this branch. It suggests that it's not testing what it's meant to.)
brianjaustin
added
Reviewed: Action Needed
and removed
Coder Has Actioned Review
labels
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6622
Purpose
Adjusts the margins for
.userstuffdlandddelements within.faqcontainers to be smaller.Testing Instructions
These margins can be seen on the
/faqpath (although there does not seem to be any FAQ data on my local...)Credit
calm (they/them)