Drop Python 3.6 from CI (Github Actions) config #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do have other choices here. We could indeed just stuck with Ubuntu 20.04. We could run two workflows, one on ubuntu-latest to test 3.7 and later, one on ubuntu 20.04 to test 3.6. But on the whole I think I'm fine with this. What does everyone else think? |
We can't test on Python 3.6 using the setup-python action with ubuntu-latest any more, as ubuntu-latest changed from 20.04 to 22.04 and 22.04 doesn't have Python 3.6. Let's just drop 3.6 testing and note in the README that we can no longer guarantee compatibility with 3.6. Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
changed the title
This was referenced Dec 1, 2022
kalikiana
approved these changes
Dec 1, 2022
|
Uhm, python 3.6 is the version of SLE15 and Leap 15 so I would prefer if we keep the support for a bit longer |
I just realized that os-autoinst/openqa_review#217 is also affected - so I'm trying out the alternative option of using a different image. If that works we could also do that here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't test on Python 3.6 using the setup-python action with ubuntu-latest any more, as ubuntu-latest changed from 20.04 to 22.04 and 22.04 doesn't have Python 3.6. Let's just drop 3.6 testing and note in the README that we can no longer guarantee compatibility with 3.6.
Signed-off-by: Adam Williamson awilliam@redhat.com