Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate tests with minimum version #4198

Conversation

HideakiImamura
Copy link
Member

@HideakiImamura HideakiImamura commented Nov 21, 2022

Motivation

To fix the CI.

The latest release of setuptools breaks the installation of libraries using numpy.distutils. See pypa/setuptools#3693 and numpy/numpy#22623.

This PR suggests to avoid the latest setuptools when we use libraries using numpy.distutils, that is, the tests with minimum versions. This is a temporary fix. We don't have to avoid the latest setuptools for normal tests, so I isolate the normal tests and those with minimum versions.

The merits of this isolation are as follows.

  • As the current problem suggests, tests with minimum versions are fragile. It is possible for a version unspecified library update to cause a test to fail at an unexpected time. By splitting up the workflow, when a test fails, it becomes clear whether the problem is with tests with minimum versions or not.
  • In addition, in the current GitHub Actions configuration, normal tests are required, but tests with minimum versions are not. If they are in the same workflow, a failure of tests with minimum versions may cause the entire workflow to be canceled and the required tests to not be executed.

Description of the changes

  • Isolate the normal tests and tests with minimum versions.
  • Add version constraint setuptools<65.6.0 for tests with minimum versions.

@HideakiImamura HideakiImamura added the CI Continuous integration. label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant